From db2de9d7e96bc858f032713027dfe245e0378cdb Mon Sep 17 00:00:00 2001 From: Rolando Santamaria Maso Date: Sat, 1 May 2021 13:28:09 +0200 Subject: [PATCH] updating documentation related to donations --- .github/ISSUE_TEMPLATE/bug_report.md | 14 +++++++------- .github/ISSUE_TEMPLATE/feature_request.md | 12 ++++++++---- README.md | 16 ++++++---------- 3 files changed, 21 insertions(+), 21 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md index dd84ea7..9c3c2b2 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.md +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -7,32 +7,32 @@ assignees: '' --- -**Describe the bug** +**Describe the bug** A clear and concise description of what the bug is. -**To Reproduce** +**To Reproduce** Steps to reproduce the behavior: 1. Go to '...' 2. Click on '....' 3. Scroll down to '....' 4. See error -**Expected behavior** +**Expected behavior** A clear and concise description of what you expected to happen. -**Screenshots** +**Screenshots** If applicable, add screenshots to help explain your problem. -**Desktop (please complete the following information):** +**Desktop (please complete the following information):** - OS: [e.g. iOS] - Browser [e.g. chrome, safari] - Version [e.g. 22] -**Smartphone (please complete the following information):** +**Smartphone (please complete the following information):** - Device: [e.g. iPhone6] - OS: [e.g. iOS8.1] - Browser [e.g. stock browser, safari] - Version [e.g. 22] -**Additional context** +**Additional context** Add any other context about the problem here. diff --git a/.github/ISSUE_TEMPLATE/feature_request.md b/.github/ISSUE_TEMPLATE/feature_request.md index bbcbbe7..2169838 100644 --- a/.github/ISSUE_TEMPLATE/feature_request.md +++ b/.github/ISSUE_TEMPLATE/feature_request.md @@ -7,14 +7,18 @@ assignees: '' --- -**Is your feature request related to a problem? Please describe.** +**Have you contributed with at least a little donation to support the development of this project?** +- Paypal: https://www.paypal.me/kyberneees +- [TRON](https://www.binance.com/en/buy-TRON) Wallet: `TJ5Bbf9v4kpptnRsePXYDvnYcYrS5Tyxus` + +**Is your feature request related to a problem? Please describe.** A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] -**Describe the solution you'd like** +**Describe the solution you'd like** A clear and concise description of what you want to happen. -**Describe alternatives you've considered** +**Describe alternatives you've considered** A clear and concise description of any alternative solutions or features you've considered. -**Additional context** +**Additional context** Add any other context or screenshots about the feature request here. diff --git a/README.md b/README.md index 75444fc..362bcf3 100644 --- a/README.md +++ b/README.md @@ -196,18 +196,18 @@ service.get('/throw', (req, res) => { #### errorHandler not being called? > Issue: https://github.com/jkyberneees/ana/issues/81 -Some middlewares don't call `return next()` inside a synchronous flow. In restana (https://github.com/jkyberneees/ana/blob/master/index.js#L99) we enable async errors handling by default, however this mechanism fails when a subsequent middleware is just calling `next()` in a sync/async flow. +Some middlewares don't call `return next()` inside a synchronous flow. In restana we enable async errors handling by default, however this mechanism fails when a subsequent middleware is just calling `next()` inside a sync or async flow. Known incompatible middlewares: -- body-parser +- body-parser (https://www.npmjs.com/package/body-parser) -How to bring async compatibility to existing middlewares? The `body-parser` example: +How to bring async chain compatibility to existing middlewares? The `body-parser` example: ```js const jsonParser = require('body-parser').json() const service = require('restana')() service.use((req, res, next) => { - return new Promise((resolve, reject) => { + return new Promise(resolve => { jsonParser(req, res, (err) => { return resolve(next(err)) }) @@ -466,9 +466,5 @@ https://goo.gl/forms/qlBwrf5raqfQwteH3 ## Support / Donate 💚 You can support the maintenance of this project: -- Paypal: https://www.paypal.me/kyberneees -- NANO Crypto Coin: `nano_3zm9steh8mb374f8be3rbytqhgzzarczhwtxhihkqt83a4m46oa3xidfiauc` -- XRP Crypto Coin: `rarQgNuiqF9gFLLwd5fdku4jYa9EXpiyCp` -- TRON Crypto Coin: `TJ5Bbf9v4kpptnRsePXYDvnYcYrS5Tyxus` -- BITCOIN Crypto Coin: `bc1qcrr58venyh54ztvkqym39p9rhnxg4308t0802f` -- Ethereum Crypto Coin: `0xD73c8E63a83eBD8Df3fB3d0090f1fe7a1eEB980B` +- PayPal: https://www.paypal.me/kyberneees +- [TRON](https://www.binance.com/en/buy-TRON) Wallet: `TJ5Bbf9v4kpptnRsePXYDvnYcYrS5Tyxus` \ No newline at end of file