Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Msig configuration for Cow TWAP feature #1423

Open
petrovska-petro opened this issue Oct 11, 2023 · 1 comment
Open

Msig configuration for Cow TWAP feature #1423

petrovska-petro opened this issue Oct 11, 2023 · 1 comment
Assignees

Comments

@petrovska-petro
Copy link
Collaborator

No description provided.

@petrovska-petro
Copy link
Collaborator Author

petrovska-petro commented May 21, 2024

fallback handler

it can be changed by design to support features not natively supported by safe, such as erc1271 signatures, which its the signature type leverage in the composable cow orders. Without its support the safe is limited to read/automate the twap intents.

erc1271 is read only type of verification, so no concerns in regards to funds getting away in an expected manner. only the settlement sc has ability/permission for the swap

requires calling setFallbackHandler to upgrade to the extensible fallback handler instead of default

twap sc requires implementing isValidSignature(bytes32,bytes), where bytes32 is the EIP-712 digest of the GPv2Order.Data. This already is handled by their ui while creating the twap orders

extensible fallback handler in a nutshell

allows a safe to validate a EIP-1271 signature and allows delegating an EIP-712 domain to a custom contract

ComposableCoW therefore will process ALL EIP-1271 signatures for the GPv2Settlement.domainSeparator() EIP-712 domain.

how orders are indexed?

two events are being tracked from the watchtower:

  1. ConditionalOrderCreated
  2. MerkleRootSet

technical resources to dive deeper

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant