Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditional using statements should not be sorted #276

Closed
ccecvb opened this issue Dec 4, 2024 · 2 comments · Fixed by #278
Closed

Conditional using statements should not be sorted #276

ccecvb opened this issue Dec 4, 2024 · 2 comments · Fixed by #278
Assignees
Labels
bug Something isn't working

Comments

@ccecvb
Copy link

ccecvb commented Dec 4, 2024

I formatted a source containing conditional using statements

The usings are sorted without taking the conditional code into account

e.g.
using be.cce.SmartTools.Images.ImageProvider from propath. is moved out of the &if
using be.cce.ccetools.tools.I18N from propath. is moved into the &if

image

@PauliusKu PauliusKu added the bug Something isn't working label Dec 4, 2024
@PauliusKu
Copy link
Collaborator

PauliusKu commented Dec 4, 2024

Yep, that's an issue here. I'm not sure if we'll be able to solve this without fixing preprocessor directives first. But we'll try.

@ccecvb
Copy link
Author

ccecvb commented Dec 4, 2024

No need to try for me
If the preprocessor directives are not formatted correctly, this source has to be fixed manually, after formatting, anyway.
Fixing preprocessor directives would have a higher priority for me because appbuilder defines are changed incorrectly as well

&if defined becomes &IFdefineD
image

@gustason gustason linked a pull request Dec 9, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants