fix(issue-34): dispose child when duration is zero #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@renefloor can you help review this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ fix issue #34
The child is not getting disposed due to animation controller not giving callbacks when the duration is zero
🆕 What is the new behavior (if this is a feature change)?
set the hide widget to true explicity when the direction is reverse and duration is zero
💥 Does this PR introduce a breaking change?
NO
🐛 Recommendations for testing
📝 Links to relevant issues/docs
#34
Baseflow/flutter_cached_network_image#942
🤔 Checklist before submitting