Impl into string for set_order_id

Author: Thomas Luijken

stellar_rust_sdk/src/horizon_client.rs

@@ -940,7 +940,7 @@ impl HorizonClient {
     /// # let horizon_client = HorizonClient::new(base_url)
     /// #    .expect("Failed to create Horizon Client");
     /// let request = SingleOfferRequest::new()
-    ///     .set_offer_id("1".to_string()) // example offer ID
+    ///     .set_offer_id("1") // example offer ID
     ///     .unwrap();
     ///
     /// let response = horizon_client.get_single_offer(&request).await;
@@ -1608,7 +1608,7 @@ impl HorizonClient {
     /// # let horizon_client = HorizonClient::new(base_url)
     /// #    .expect("Failed to create Horizon Client");
     /// let request = TradesForOfferRequest::new()
-    ///    .set_offer_id("42".to_string())
+    ///    .set_offer_id("42")
     ///    .unwrap();
     ///
     /// let response = horizon_client.get_trades_for_offer(&request).await;

stellar_rust_sdk/src/lib.rs

@@ -410,7 +410,7 @@ pub mod liquidity_pools;
 ///
 /// // Example: Fetching all effects
 /// let single_offer_request = SingleOfferRequest::new()
-///     .set_offer_id("1".to_string())
+///     .set_offer_id("1")
 ///     .unwrap();
 /// let single_offer_response = horizon_client.get_single_offer(&single_offer_request).await?;
 ///

stellar_rust_sdk/src/offers/mod.rs

@@ -110,7 +110,7 @@ pub mod test {
         let horizon_client = HorizonClient::new("https://horizon-testnet.stellar.org").unwrap();
 
         let single_offer_request = SingleOfferRequest::new()
-            .set_offer_id(OFFER_ID.to_string())
+            .set_offer_id(OFFER_ID)
             .unwrap();
 
         let single_offer_response = horizon_client.get_single_offer(&single_offer_request).await;

stellar_rust_sdk/src/offers/single_offer_request.rs

@@ -29,7 +29,7 @@ pub struct NoOfferId;
 /// # use stellar_rs::offers::prelude::SingleOfferRequest;
 /// # use stellar_rs::models::Request;
 /// let request = SingleOfferRequest::new()
-///     .set_offer_id("1".to_string()); // example offer ID
+///     .set_offer_id("1"); // example offer ID
 ///
 /// // Use with HorizonClient::get_single_offer
 /// ```
@@ -54,7 +54,8 @@ impl SingleOfferRequest<NoOfferId> {
     /// # Returns
     /// A `SingleOfferRequest` with the specified offer ID, or an error if the offer ID is invalid.
     ///
-    pub fn set_offer_id(self, offer_id: String) -> Result<SingleOfferRequest<OfferId>, String> {
+    pub fn set_offer_id(self, offer_id: impl Into<String>) -> Result<SingleOfferRequest<OfferId>, String> {
+        let offer_id = offer_id.into();
         match offer_id.parse::<u32>() {
             Ok(id) => {
                 if id > 0 {

stellar_rust_sdk/src/trades/mod.rs

@@ -419,7 +419,7 @@ pub mod test {
         const PRICE_D: &str = "10";
 
         let trades_for_offer_request = TradesForOfferRequest::new()
-            .set_offer_id(OFFER_ID.to_string())
+            .set_offer_id(OFFER_ID)
             .unwrap();
         let horizon_client = HorizonClient::new("https://horizon-testnet.stellar.org").unwrap();
         let trades_for_liquidity_pools_response = horizon_client

stellar_rust_sdk/src/trades/trades_for_offer_request.rs

@@ -32,10 +32,10 @@ impl TradesForOfferRequest<TradeOfferId> {
     ///
     pub fn set_offer_id(
         self,
-        offer_id: String,
+        offer_id: impl Into<String>,
     ) -> Result<TradesForOfferRequest<TradeOfferId>, String> {
         Ok(TradesForOfferRequest {
-            offer_id: TradeOfferId(offer_id),
+            offer_id: TradeOfferId(offer_id.into()),
             cursor: self.cursor,
             limit: self.limit,
             order: self.order,