Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Iterative Lightening/Darkening #2

Open
lounsbrough opened this issue May 26, 2023 · 0 comments
Open

Remove Iterative Lightening/Darkening #2

lounsbrough opened this issue May 26, 2023 · 0 comments

Comments

@lounsbrough
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
There is a potential performance improvement.

Describe the solution you'd like
It would be great if we did not have to iteratively lighten/darken a color and keep checking if contrast has been satisfied, or that we can not lighten/darken any further.

Describe alternatives you've considered
I tried various formulas to try and compute the necessary lightness to apply to a color to achieve the target relative luminance. The various methods I tried got close, but were never quite right.

Additional context
The performance impact of the current solution seems to be minimal, but it would be cool to remove the lightening/darkening iteration at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant