Skip to content

Commit f7be996

Browse files
committed
feat: raises if name is invalid
Signed-off-by: Eduardo Borsa <borsa.dado@gmail.com>
1 parent c2f46e7 commit f7be996

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

lib/mix/tasks/install.ex

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -338,6 +338,7 @@ defmodule Mix.Tasks.Beacon.Install do
338338

339339
cond do
340340
!Beacon.Types.Site.valid?(site) -> raise_with_help!("Invalid site name. It should not contain special characters.")
341+
!Beacon.Types.Site.valid_name?(site) -> raise_with_help!("Invalid site name. The site name can't start with \"beacon_\".")
341342
:default -> options
342343
end
343344
end

test/mix/tasks/install_test.exs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -443,6 +443,11 @@ defmodule Mix.Tasks.Beacon.InstallTest do
443443
Install.run(["--site", "my@site!"])
444444
end
445445

446+
# Invalid site name
447+
assert_raise Mix.Error, fn ->
448+
Install.run(["--site", "beacon_"])
449+
end
450+
446451
# Invalid option
447452
assert_raise OptionParser.ParseError, ~r/1 error found!\n--invalid-argument : Unknown option/, fn ->
448453
Install.run(["--invalid-argument", "invalid"])

0 commit comments

Comments
 (0)