From 486643b10451db5e7786fb837f0d432cd0409502 Mon Sep 17 00:00:00 2001 From: Sihu Hwang <129564966+hwangsihu@users.noreply.github.com> Date: Sat, 11 Apr 2026 15:46:13 +0900 Subject: [PATCH 1/2] Makefile: Do not force Ninja for building --- Build/Makefile | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Build/Makefile b/Build/Makefile index 83baecf721..9a49d8d6da 100644 --- a/Build/Makefile +++ b/Build/Makefile @@ -1,6 +1,5 @@ TEAMTALK_ROOT?=$(PWD)/.. CONFIGTYPE?=release -CMAKE_GENERATOR?=Ninja SHELL := /bin/bash @@ -19,7 +18,7 @@ teamtalk-env: genlib: mkdir -p $(BUILDDIR) - cd $(BUILDDIR) && cmake $(CMAKE_EXTRA) -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DCMAKE_BUILD_TYPE=$(CONFIGTYPE) -G "$(CMAKE_GENERATOR)" ../../ + cd $(BUILDDIR) && cmake $(CMAKE_EXTRA) -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DCMAKE_BUILD_TYPE=$(CONFIGTYPE) ../../ buildlib: genlib cmake --build $(BUILDDIR) $(CMAKE_BUILD_EXTRA) From fbfbeb2a9ef91910718e6c84f06c992e080a8a23 Mon Sep 17 00:00:00 2001 From: Sihu Hwang <129564966+hwangsihu@users.noreply.github.com> Date: Sat, 11 Apr 2026 15:48:21 +0900 Subject: [PATCH 2/2] Use Ninja on GitHub Actions --- .github/workflows/android.yml | 2 +- .github/workflows/ios.yml | 2 +- .github/workflows/macos.yml | 2 +- .github/workflows/ubuntu.yml | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/android.yml b/.github/workflows/android.yml index 85e43864dd..b3c11c81fc 100644 --- a/.github/workflows/android.yml +++ b/.github/workflows/android.yml @@ -56,7 +56,7 @@ jobs: - name: Build TeamTalk library for Android working-directory: ${{github.workspace}}/Build - run: make CMAKE_EXTRA="-DFEATURE_WEBRTC=OFF -DCMAKE_INSTALL_PREFIX=${{runner.workspace}}/install-${{ matrix.maketarget }}" ${{ matrix.maketarget }} + run: make CMAKE_EXTRA="-G Ninja -DFEATURE_WEBRTC=OFF -DCMAKE_INSTALL_PREFIX=${{runner.workspace}}/install-${{ matrix.maketarget }}" ${{ matrix.maketarget }} env: ANDROID_NDK_HOME: ${{ steps.setup-ndk.outputs.ndk-path }} diff --git a/.github/workflows/ios.yml b/.github/workflows/ios.yml index 84c0a98dd6..20bb6becb3 100644 --- a/.github/workflows/ios.yml +++ b/.github/workflows/ios.yml @@ -31,7 +31,7 @@ jobs: - name: Build TeamTalk library working-directory: ${{github.workspace}}/Build - run: make CMAKE_EXTRA="-DFEATURE_WEBRTC=OFF -DCMAKE_OSX_ARCHITECTURES=${{ matrix.cmakearch }} -DCMAKE_OSX_SYSROOT=${{ matrix.cmakesysroot }} -DTOOLCHAIN_INSTALL_PREFIX=${{runner.workspace}}/toolchain-${{ matrix.cmakearch }} -DCMAKE_INSTALL_PREFIX=${{runner.workspace}}/install-${{ matrix.cmakearch }}" BUILDDIR=build-${{ matrix.cmakearch }} ios-build + run: make CMAKE_EXTRA="-G Ninja -DFEATURE_WEBRTC=OFF -DCMAKE_OSX_ARCHITECTURES=${{ matrix.cmakearch }} -DCMAKE_OSX_SYSROOT=${{ matrix.cmakesysroot }} -DTOOLCHAIN_INSTALL_PREFIX=${{runner.workspace}}/toolchain-${{ matrix.cmakearch }} -DCMAKE_INSTALL_PREFIX=${{runner.workspace}}/install-${{ matrix.cmakearch }}" BUILDDIR=build-${{ matrix.cmakearch }} ios-build - name: Install TeamTalk SDK working-directory: ${{github.workspace}}/Build/build-${{ matrix.cmakearch }} diff --git a/.github/workflows/macos.yml b/.github/workflows/macos.yml index 06b72f4c69..4aee3d813a 100644 --- a/.github/workflows/macos.yml +++ b/.github/workflows/macos.yml @@ -53,7 +53,7 @@ jobs: - name: Build TeamTalk toolchain, libraries and apps working-directory: ${{github.workspace}} shell: bash - run: make CMAKE_EXTRA="-DTOOLCHAIN_INSTALL_PREFIX=${{runner.workspace}}/toolchain-install -DFEATURE_WEBRTC=OFF -DFEATURE_PORTAUDIO=OFF -DBUILD_TEAMTALK_LIBRARY_UNITTEST_CATCH2=ON -DBUILD_TEAMTALK_LIBRARY_UNITTEST_CATCH2_PERF=OFF -DBUILD_TEAMTALK_CLIENT_QTTEAMTALK_PRODUCT=ON -DCMAKE_INSTALL_PREFIX=${{runner.workspace}}/install" -C Build mac + run: make CMAKE_EXTRA="-G Ninja -DTOOLCHAIN_INSTALL_PREFIX=${{runner.workspace}}/toolchain-install -DFEATURE_WEBRTC=OFF -DFEATURE_PORTAUDIO=OFF -DBUILD_TEAMTALK_LIBRARY_UNITTEST_CATCH2=ON -DBUILD_TEAMTALK_LIBRARY_UNITTEST_CATCH2_PERF=OFF -DBUILD_TEAMTALK_CLIENT_QTTEAMTALK_PRODUCT=ON -DCMAKE_INSTALL_PREFIX=${{runner.workspace}}/install" -C Build mac - name: Start TeamTalk Standard Server working-directory: ${{github.workspace}} diff --git a/.github/workflows/ubuntu.yml b/.github/workflows/ubuntu.yml index b92453b66f..0e0f29ec4e 100644 --- a/.github/workflows/ubuntu.yml +++ b/.github/workflows/ubuntu.yml @@ -57,7 +57,7 @@ jobs: working-directory: ${{github.workspace}} run: | source env.sh - make CMAKE_EXTRA="-DFEATURE_WEBRTC=OFF -DBUILD_TEAMTALK_LIBRARY_UNITTEST_CATCH2=ON -DBUILD_TEAMTALK_LIBRARY_UNITTEST_CATCH2_PERF=OFF -DTOOLCHAIN_INSTALL_PREFIX=${{runner.workspace}}/toolchain-install -DCMAKE_INSTALL_PREFIX=${{runner.workspace}}/install" -C Build ubuntu${{ matrix.version }} + make CMAKE_EXTRA="-G Ninja -DFEATURE_WEBRTC=OFF -DBUILD_TEAMTALK_LIBRARY_UNITTEST_CATCH2=ON -DBUILD_TEAMTALK_LIBRARY_UNITTEST_CATCH2_PERF=OFF -DTOOLCHAIN_INSTALL_PREFIX=${{runner.workspace}}/toolchain-install -DCMAKE_INSTALL_PREFIX=${{runner.workspace}}/install" -C Build ubuntu${{ matrix.version }} echo TEAMTALK_INSTALLDIR=${{runner.workspace}}/install>> $GITHUB_ENV - name: Run Java Server API tests (non-encrypted)