Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drivers not installed #149

Open
ankhafizov opened this issue Aug 8, 2024 · 11 comments
Open

Drivers not installed #149

ankhafizov opened this issue Aug 8, 2024 · 11 comments
Labels
bug Something isn't working

Comments

@ankhafizov
Copy link

ankhafizov commented Aug 8, 2024

Laptop model

MSI Creator-Z16P-B12UHST

EC firmware version

cat: /sys/devices/platform/msi-ec/fw_version: No such file or directory

Description

I have executed

(base) ankhafizov@ankhafizov-Creator-Z16P-B12UHST:~/msi-ec$ sudo make dkms-install
dkms --version >> /dev/null
mkdir -p /usr/src/msi_ec-0.08
cp /home/ankhafizov/msi-ec/dkms.conf /usr/src/msi_ec-0.08
cp /home/ankhafizov/msi-ec/Makefile /usr/src/msi_ec-0.08
cp /home/ankhafizov/msi-ec/msi-ec.c /usr/src/msi_ec-0.08
cp /home/ankhafizov/msi-ec/ec_memory_configuration.h /usr/src/msi_ec-0.08
sed -e "s/@CFLGS@//" \
    -e "s/@VERSION@/0.08/" \
    -i /usr/src/msi_ec-0.08/dkms.conf
dkms add msi_ec/0.08
Creating symlink /var/lib/dkms/msi_ec/0.08/source -> /usr/src/msi_ec-0.08
dkms build msi_ec/0.08
Sign command: /usr/bin/kmodsign
Signing key: /var/lib/shim-signed/mok/MOK.priv
Public certificate (MOK): /var/lib/shim-signed/mok/MOK.der

Building module:
Cleaning build area...
make -j20 KERNELRELEASE=6.8.0-39-generic TARGET=6.8.0-39-generic CFLAGS_MODULE+=...
Signing module /var/lib/dkms/msi_ec/0.08/build/msi-ec.ko
Cleaning build area...
dkms install msi_ec/0.08

msi-ec.ko.zst:
Running module version sanity check.
 - Original module
 - Installation
   - Installing to /lib/modules/6.8.0-39-generic/updates/dkms/
depmod...
echo msi-ec > /etc/modules-load.d/msi-ec.conf

but

image

@ankhafizov ankhafizov added the bug Something isn't working label Aug 8, 2024
@ankhafizov
Copy link
Author

image

@ankhafizov
Copy link
Author

image

@mutchiko
Copy link
Contributor

mutchiko commented Aug 8, 2024

Check if your device is supported before attempting to install and use the driver. The list of supported devices can be found here

your device is not supported (yet): https://www.msi.com/Content-Creation/Creator-Z16P-B12UX/support?sub_product=Creator-Z16P-B12UHST#driver

support page doesn't show EC firmware, does this laptop even use EC?

@glpnk
Copy link
Contributor

glpnk commented Aug 8, 2024

Hi @ankhafizov, after dkms-install module is not loaded automatically, and because module is upstreamed to kernel, you need to unload kernel built-in module and then load git version.

But because your device is not yet supported, you need to follow the guide from new model issue template to send your EC dump. Your device is WMI2 based, so you can use other WMI2 based device as reference

@ankhafizov
Copy link
Author

Thank you all! Yes, device supports EC. At least cooler boost work with https://github.com/FaridZelli/ISW-Modern that is based on acpi_ec

@mutchiko
Copy link
Contributor

if you want to help us support your laptop you can try following this guide : https://github.com/mutchiko/msi-ec/wiki/How-To-Get-Your-Device-Supported

@teackot
Copy link
Collaborator

teackot commented Aug 19, 2024

@mutchiko that's a great guide, would you like to submit a PR to add it here? As a regular file though, I find the wiki less discoverable and more difficult to contribute to

@mutchiko
Copy link
Contributor

@ankhafizov Are you still interested in adding support for your laptop? you can follow the updated guide and report back the addresses and the values they contain.

@a-chris
Copy link

a-chris commented Dec 30, 2024

hello everyone, I have the same issue since I've successfully installed msi-ec

~/msi-ec$ sudo make dkms-install
dkms --version >> /dev/null
mkdir -p /usr/src/msi_ec-0.08
cp /home/home/msi-ec/dkms.conf /usr/src/msi_ec-0.08
cp /home/home/msi-ec/Makefile /usr/src/msi_ec-0.08
cp /home/home/msi-ec/msi-ec.c /usr/src/msi_ec-0.08
cp /home/home/msi-ec/ec_memory_configuration.h /usr/src/msi_ec-0.08
sed -e "s/@CFLGS@//" \
    -e "s/@VERSION@/0.08/" \
    -i /usr/src/msi_ec-0.08/dkms.conf
dkms add msi_ec/0.08
Creating symlink /var/lib/dkms/msi_ec/0.08/source -> /usr/src/msi_ec-0.08
dkms build msi_ec/0.08
Sign command: /usr/bin/kmodsign
Signing key: /var/lib/shim-signed/mok/MOK.priv
Public certificate (MOK): /var/lib/shim-signed/mok/MOK.der

Building module:
Cleaning build area...
make -j8 KERNELRELEASE=6.8.0-51-generic TARGET=6.8.0-51-generic CFLAGS_MODULE+=...
Signing module /var/lib/dkms/msi_ec/0.08/build/msi-ec.ko
Cleaning build area...
dkms install msi_ec/0.08

msi-ec.ko.zst:
Running module version sanity check.
 - Original module
 - Installation
   - Installing to /lib/modules/6.8.0-51-generic/updates/dkms/
depmod...
echo msi-ec > /etc/modules-load.d/msi-ec.conf

and running it again:

sudo make dkms-install
[sudo] password for home: 
dkms --version >> /dev/null
mkdir -p /usr/src/msi_ec-0.08
cp /home/home/msi-ec/dkms.conf /usr/src/msi_ec-0.08
cp /home/home/msi-ec/Makefile /usr/src/msi_ec-0.08
cp /home/home/msi-ec/msi-ec.c /usr/src/msi_ec-0.08
cp /home/home/msi-ec/ec_memory_configuration.h /usr/src/msi_ec-0.08
sed -e "s/@CFLGS@//" \
    -e "s/@VERSION@/0.08/" \
    -i /usr/src/msi_ec-0.08/dkms.conf
dkms add msi_ec/0.08
Error! DKMS tree already contains: msi_ec-0.08
You cannot add the same module/version combo more than once.
make: *** [Makefile:52: dkms-install] Error 3

but /sys/devices/platform/msi-ec does not exist, even after rebooting.

cd /sys/devices/platform/msi-ec
-bash: cd: /sys/devices/platform/msi-ec: No such file or directory

I have a MSI PS63 Modern 8RC, firmware E16S1IMS.109 (latest available). Do you have clue why it's happening?

Let me know if I can give you more info

@glpnk
Copy link
Contributor

glpnk commented Dec 30, 2024

@a-chris Hi, your device is not supported yet, follow this guide device_support_guide.md and open new issue

To get required info for opening issue, follow debug-mode paragraph

@a-chris
Copy link

a-chris commented Jan 3, 2025

I wasn’t able to enable debug mode to open the issue earlier, but today I managed to fix it by toggling Secure Boot on and then off again. This allowed me to finally enable debug-mode and create the issue for my device. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants