fix: cloud uploads on diff scans (#1327)

* fix: cloud uploads on diff scans

* fix: remove unused flag

Author: elsapet

internal/commands/artifact/run.go

@@ -380,6 +380,7 @@ func (r *runner) Report(
 	if err != nil {
 		return false, err
 	}
+	reportoutput.UploadReportToCloud(reportData, r.scanSettings)
 
 	endTime := time.Now()
 

internal/report/output/output.go

@@ -9,6 +9,7 @@ import (
 	"github.com/google/uuid"
 	"github.com/hhatto/gocloc"
 	"golang.org/x/exp/maps"
+	"golang.org/x/exp/slices"
 
 	"github.com/bearer/bearer/internal/commands/process/settings"
 	"github.com/bearer/bearer/internal/flag"
@@ -52,19 +53,15 @@ func GetData(
 	}
 
 	// add report-specific items
-	attemptCloudUpload := false
 	switch config.Report.Report {
 	case flag.ReportDataFlow:
 		return data, err
 	case flag.ReportSecurity:
-		attemptCloudUpload = true
 		err = security.AddReportData(data, config, baseBranchFindings)
 	case flag.ReportSaaS:
 		if err = security.AddReportData(data, config, baseBranchFindings); err != nil {
 			return nil, err
 		}
-
-		attemptCloudUpload = true
 		err = saas.GetReport(data, config, false)
 	case flag.ReportPrivacy:
 		err = privacy.AddReportData(data, config)
@@ -74,15 +71,17 @@ func GetData(
 		return nil, fmt.Errorf(`--report flag "%s" is not supported`, config.Report.Report)
 	}
 
-	if attemptCloudUpload && config.Client != nil && config.Client.Error == nil {
-		// send SaaS report to Cloud
-		data.SendToCloud = true
-		saas.SendReport(config, data)
-	}
-
 	return data, err
 }
 
+func UploadReportToCloud(report *types.ReportData, config settings.Config) {
+	if slices.Contains([]string{flag.ReportSecurity, flag.ReportSaaS}, config.Report.Report) {
+		if config.Client != nil && config.Client.Error == nil {
+			saas.SendReport(config, report)
+		}
+	}
+}
+
 func GetDataflow(reportData *types.ReportData, report globaltypes.Report, config settings.Config, isInternal bool) error {
 	if reportData.Detectors == nil {
 		if err := detectors.AddReportData(reportData, report, config); err != nil {

internal/report/output/types/types.go

@@ -10,7 +10,6 @@ import (
 
 type ReportData struct {
 	ReportFailed              bool
-	SendToCloud               bool
 	Files                     []string
 	FoundLanguages            []string
 	Detectors                 []any