Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SimpleFilterParser - better reporting #2

Open
douglm opened this issue Nov 2, 2016 · 0 comments
Open

SimpleFilterParser - better reporting #2

douglm opened this issue Nov 2, 2016 · 0 comments
Assignees

Comments

@douglm
Copy link
Member

douglm commented Nov 2, 2016

For example: this expression
(vpath="/user/agrp_calsuite-MainCampus/Ongoing") and (entity_type="event"|entity_type="todo")
results in a null filter if that path is unavailable.

This code should throw an error if it tries to return null (note the caller does but we don't see the context)

if (pi.equals(PropertyInfoIndex.VPATH)) {
  checkSub(pis, 1);
  // expect list of virtual paths.
  final ArrayList<String> vpaths = doWordList();

  for (final String vpath: vpaths) {
    final FilterBase vpf = resolveVpath(vpath);

    if (vpf == null) {
      continue;
    }

    filter = and(filter, vpf);
  }

  return filter;
}
@douglm douglm self-assigned this Nov 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant