Fix warnings: conversion to double/float, unused variables, register keyword

Author: 0v3rt1r3d

CMakeLists.txt

@@ -538,6 +538,10 @@ pkg_check_modules(LCMS REQUIRED lcms2>=2.6)
 pkg_check_modules(EXPAT REQUIRED expat>=2.1)
 pkg_check_modules(FFTW3F REQUIRED fftw3f)
 
+# By default little-cms2 uses 'register' keyword which is deprecated and removed in c++17
+# This definition forces not to use it
+add_definitions("-DCMS_NO_REGISTER_KEYWORD")
+
 #Set the appropriate FFTW flags on macOS
 if(APPLE AND OPTION_OMP)
         set(EXTRA_LIB "-L${LOCAL_PREFIX}/lib -lfftw3f_omp -lfftw3f -lm")

rtengine/dfmanager.cc

@@ -317,7 +317,6 @@ class rtengine::DFManager::Implementation final :
     typedef std::map<std::string, std::vector<badPix> > bpList_t;
     dfList_t dfList;
     bpList_t bpList;
-    bool initialized;
     Glib::ustring currentPath;
     dfInfo* addFileInfo(const Glib::ustring &filename, bool pool = true);
     dfInfo* find(const std::string &mak, const std::string &mod, int isospeed, double shut, time_t t);

rtengine/rawimagesource.cc

@@ -5307,8 +5307,8 @@ void RawImageSource::ItcWB(bool extra, double &tempref, double &greenref, double
         Glib::ustring profuse;
         profuse = "JDCmax";
 
-        int limx = 0.05f;
-        int limy = 0.04f;
+        float limx = 0.05f;
+        float limy = 0.04f;
 
         if (wbpar.itcwb_prim == "srgb") {
             profuse = "sRGB";

rtgui/dirbrowser.cc

@@ -393,7 +393,9 @@ Gtk::TreePath DirBrowser::expandToDir (const Glib::ustring& absDirPath)
 
     char* dcpy = strdup (absDirPath.c_str());
     char* dir = strtok (dcpy, "/\\");
+#ifdef _WIN32
     int count = 0;
+#endif
     expandSuccess = true;
 
 #ifndef _WIN32
@@ -436,8 +438,9 @@ Gtk::TreePath DirBrowser::expandToDir (const Glib::ustring& absDirPath)
             ++ix;
             ++i;
         }
-
+#ifdef _WIN32
         count++;
+#endif
         dir = strtok(nullptr, "/\\");
     }
 

rtgui/editwindow.h

@@ -24,7 +24,7 @@
 #include "guiutils.h"
 
 class EditorPanel;
-class ExternalEditor;
+struct ExternalEditor;
 class RTWindow;
 
 class EditWindow :

rtgui/flatfield.cc

@@ -445,7 +445,7 @@ void FlatField::setGainMap(bool enabled) {
     flatFieldFromMetaData->set_sensitive(enabled);
     if (!enabled) {
         idle_register.add(
-            [this, enabled]() -> bool
+            [this]() -> bool
             {
                 disableListener();
                 flatFieldFromMetaData->setValue(false);

rtgui/lockablecolorpicker.h

@@ -30,7 +30,7 @@ namespace rtengine
 namespace procparams
 {
 
-class ColorManagementParams;
+struct ColorManagementParams;
 
 }
 

rtgui/pointermotionlistener.h

@@ -28,7 +28,7 @@ namespace rtengine
 namespace procparams
 {
 
-class ColorManagementParams;
+struct ColorManagementParams;
 
 }