-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-open Generalized Hyperbolic Stretch #7251
base: dev
Are you sure you want to change the base?
Conversation
Co-authored-by: Lawrence37 <45837045+Lawrence37@users.noreply.github.com>
Co-authored-by: Lawrence37 <45837045+Lawrence37@users.noreply.github.com>
Co-authored-by: Lawrence37 <45837045+Lawrence37@users.noreply.github.com>
Co-authored-by: Lawrence37 <45837045+Lawrence37@users.noreply.github.com>
Co-authored-by: Lawrence37 <45837045+Lawrence37@users.noreply.github.com>
Co-authored-by: Lawrence37 <45837045+Lawrence37@users.noreply.github.com>
Co-authored-by: Lawrence37 <45837045+Lawrence37@users.noreply.github.com>
Co-authored-by: Lawrence37 <45837045+Lawrence37@users.noreply.github.com>
Co-authored-by: Lawrence37 <45837045+Lawrence37@users.noreply.github.com>
Co-authored-by: Lawrence37 <45837045+Lawrence37@users.noreply.github.com>
Co-authored-by: Lawrence37 <45837045+Lawrence37@users.noreply.github.com>
Co-authored-by: Lawrence37 <45837045+Lawrence37@users.noreply.github.com>
Co-authored-by: Lawrence37 <45837045+Lawrence37@users.noreply.github.com>
Co-authored-by: Lawrence37 <45837045+Lawrence37@users.noreply.github.com>
Co-authored-by: Lawrence37 <45837045+Lawrence37@users.noreply.github.com>
Co-authored-by: Lawrence37 <45837045+Lawrence37@users.noreply.github.com>
Co-authored-by: Lawrence37 <45837045+Lawrence37@users.noreply.github.com>
Co-authored-by: Lawrence37 <45837045+Lawrence37@users.noreply.github.com>
This PR as well as the one on Abstract profile highlights - beyond the technical aspects and understanding of the algorithms - the following difficulties (not exhaustive)
Jacques |
Co-authored-by: Lawrence37 <45837045+Lawrence37@users.noreply.github.com>
Co-authored-by: Lawrence37 <45837045+Lawrence37@users.noreply.github.com>
Co-authored-by: Lawrence37 <45837045+Lawrence37@users.noreply.github.com>
Co-authored-by: Lawrence37 <45837045+Lawrence37@users.noreply.github.com>
My intention is not to change all the usages of "luma" into "lightness". Doing so does not resolve any problems for me. My point in asking why it is luma instead of lightness is because I don't know which one the code is using. If the code is really using luma, then it should be kept as luma (and clarifications should be made on what L and ab refer to if it is not CIELAB). If the code is really using lightness, then I am fine with the change. As of now, I have not looked at the code, so I don't know which one is correct. |
@Lawrence37 I had to "tinker" with Jz so that there was a Lightness value... We have already had this debate, without any real solution for all cases. With you, the advantage is a "new" reader, therefore more representative. So I opt for the choice of Lightness and not Luma. thank you for this review. I will be away 2 days, but maybe I would have an internet connection Jacques |
I accidentally merged the PR GHS #7210
I reverted with the PR 7250
I open this new PR... same code