Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] egg error when using argument D #1490

Closed
gooostaw opened this issue Oct 13, 2024 · 1 comment · Fixed by #1491
Closed

[BUG] egg error when using argument D #1490

gooostaw opened this issue Oct 13, 2024 · 1 comment · Fixed by #1491
Assignees

Comments

@gooostaw
Copy link

Describe the bug
The egg function doesn't work if I use the D argument instead of R.

Code To Reproduce Bug

include <BOSL2/std.scad>
egg(78,d1=50,d2 = 25, D = 100);

Additional context
shapes2d.scad line 1475

D = get_radius(r1=R, d1=D)

should be changed to

R = get_radius(r1=R, d1=D)

am I right? ;)

@adrianVmariano
Copy link
Collaborator

You're sorta right. There's a second problem. I think it works in the PR.

@adrianVmariano adrianVmariano linked a pull request Oct 14, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants