Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

three bugs and their fixes in comm() function #72

Open
volkirik opened this issue Jan 1, 2024 · 2 comments
Open

three bugs and their fixes in comm() function #72

volkirik opened this issue Jan 1, 2024 · 2 comments

Comments

@volkirik
Copy link

volkirik commented Jan 1, 2024

first one:

$this->write($com, ($count===0));

second (query commands need to be send with question mark)

                    case "?":
                        $el = "?$k=$v";

third (hang forever):

                $last = ($i === $count - 1);
                $this->write($el, $last);
				$i++;
@Chupaka
Copy link

Chupaka commented Jan 2, 2024

Any context here?..

What regards to

case "?":
$el = "?$k=$v";

It's switch ($k[0]), so your result will be something like ??key=val

@BenMenking
Copy link
Owner

@volkirik thank you for the report! Can you provide any testing scenarios that can be run to duplicate the three issues?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants