GenerateBorder modifier not compatible with NoiseGenerator

[Zehir]

Hello,

For some reason the GenerateBorder modifier is not compatible with NoiseGenerator but it's worked.

I used the NoiseGenerator to generate an island and wanted to use the GenerateBorder modifier for the beach.

But the code of the modifier is checking for a tile property;

Gaea/addons/gaea/modifiers/2D/generate_borders.gd

Lines 21 to 26 in 23561ce

	func apply(grid: GaeaGrid, generator: GaeaGenerator) -> void:
	# Check if the generator has a "settings" variable and if those
	# settings have a "tile" variable.
	if not generator.get("settings") or not generator.settings.get("tile"):
	push_warning("GenerateBorder modifier not compatible with %s" % generator.name)
	return

The NoiseGenerator don't have a tile property but a tiles property.
If I manually update the guard clause to allow the NoiseGenerator I get correct result;

The water was added using the GenerateBorder modifier.

Is there any side beavior I don't see there ?

[cullumi]

From what I can tell, you're spot on! The Generate Borders method does not even use the Generator Settings at all; we should actually be able to remove the guard clause entirely. It can always be added in should the functionality of the Generate Borders modifier change in the future.