Skip to content

Add "Display Name" field to Admin UI snippet #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
netmikey opened this issue Nov 2, 2020 · 4 comments
Open

Add "Display Name" field to Admin UI snippet #5

netmikey opened this issue Nov 2, 2020 · 4 comments

Comments

@netmikey
Copy link

netmikey commented Nov 2, 2020

According to this post, Apple requires a very specific wording for its Sign-In buttons. That would be easily achievable using the "Display Name" property present in the generic OIDC provider you're inheriting from. However, your Admin UI snippet is lacking that field. Could you please add the following snippet to realm-identity-provider-apple-ext.html as suggested by ebiscardi:

<div class="form-group clearfix">
   <label class="col-md-2 control-label" for="displayName"> {{:: 'display-name' | translate}}</label>
    <div class="col-md-6">
        <input class="form-control" id="displayName" type="text" ng-model="identityProvider.displayName">
    </div>
    <kc-tooltip>{{:: 'identity-provider.display-name.tooltip' | translate}}</kc-tooltip>
</div>
@netmikey netmikey changed the title Add Add "Display Name" field to Admin UI snippet Nov 2, 2020
@SalahAdDin
Copy link

@netmikey Did you try to make a pull request?

@netmikey
Copy link
Author

netmikey commented Feb 6, 2021

No I haven't, I have overwritten the whole realm-identity-provider-apple-ext.html in my project and have added those lines.

@SalahAdDin
Copy link

@netmikey It could be gread if you create a pull request to improve this repo.

@SalahAdDin
Copy link

@netmikey @BenjaminFavre It could be related to keycloak/keycloak#7323 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants