fix(test/main): always call prif_init

This commit fixes a problem that caused seg faults when running
subsets test. Previously, if the subset didn't include the
prif_init test, then prif_init was never called.  This commit calls
prif_init in test/main.F90 before running the tests.  Consequently,
the test for normal execution of prif_init now happens via an
assertion rather than in a unit test.

Author: rouson

test/main.F90

@@ -1,7 +1,7 @@
 ! Copyright (c) 2024, The Regents of the University of California and Sourcery Institute
 ! Terms of use are as specified in LICENSE.txt
 
-!#include "assert_macros.h"
+#include "assert_macros.h"
 
 program main
   !! Test the Caffeine implementation of the Parallel Runtime Interface for Fortran (PRIF)
@@ -30,13 +30,15 @@ program main
   use prif_this_image_test_m, only : prif_this_image_test_t
   implicit none
 
+  integer, parameter :: successful=0
   integer :: passes=0, tests=0
-  integer me
+  integer me, init_status
 
   call stop_and_print_usage_info_if_help_requested
+  call prif_init(stat=init_status)
+  call_assert(init_status==successful)
   call run_tests_and_report(passes, tests)
   call prif_this_image_no_coarray(this_image=me)
-
   if (me==1) print "(a,*(a,G0))", new_line(''), "_________ In total, ",passes," of ",tests, " tests pass. _________"
   call prif_sync_all
   if (passes /= tests) call prif_error_stop(quiet=.false._c_bool)

test/prif_init_test_m.F90

@@ -34,46 +34,29 @@ function results() result(test_results)
 
 #if HAVE_PROCEDURE_ACTUAL_FOR_POINTER_DUMMY
     test_descriptions = [ & 
-      test_description_t("completing normally when called once", check_caffeination), &
-      test_description_t("returning PRIF_STAT_ALREADY_INIT when called a second time", check_subsequent_prif_init_call) &
+      test_description_t("returning PRIF_STAT_ALREADY_INIT when called a second time", check_redundant_prif_init_call) &
     ]   
 #else
-    procedure(test_function_i), pointer :: check_caffeination_ptr, check_subsequent_prif_init_call_ptr 
-
-    check_caffeination_ptr              =>  check_caffeination
-    check_subsequent_prif_init_call_ptr => check_subsequent_prif_init_call
+    procedure(test_function_i), pointer :: check_caffeination_ptr, check_redundant_prif_init_call_ptr 
+    check_redundant_prif_init_call_ptr => check_redundant_prif_init_call
 
     test_descriptions = [ & 
-       test_description_t("completing normally when called once", check_caffeination_ptr) &
-      ,test_description_t("returning PRIF_STAT_ALREADY_INIT when called a second time", check_subsequent_prif_init_call_ptr) &
+      test_description_t("returning PRIF_STAT_ALREADY_INIT when called a second time", check_redundant_prif_init_call_ptr) &
     ]   
 #endif
 
     test_descriptions = pack(test_descriptions, &
       index(subject(), test_description_substring) /= 0  &
       .or. test_descriptions%contains_text(test_description_substring))
-      
     test_results = test_descriptions%run()
   end function
 
-    function check_caffeination() result(test_passes)
-      !! check program initiation
+    function check_redundant_prif_init_call()  result(test_passes)
       logical test_passes
-      integer, parameter :: successful_initiation = 0
-      integer init_exit_code
-
-      call prif_init(init_exit_code)
-      test_passes = init_exit_code == successful_initiation
-    end function
-
-    function check_subsequent_prif_init_call()  result(test_passes)
-      logical test_passes
-
-        integer :: stat
-
-        call prif_init(stat)
-        call prif_init(stat)
-        test_passes = stat == PRIF_STAT_ALREADY_INIT
+      integer stat
+      call prif_init(stat)
+      call prif_init(stat)
+      test_passes = stat == PRIF_STAT_ALREADY_INIT
     end function
 
 end module prif_init_test_m