refactor testing code, workflow

Author: yzhoubk

spec/features/download_zipfile_spec.rb

@@ -6,42 +6,46 @@
   let(:download_dir) { '/opt/app/tmp/selenium_downloads' }
   let(:zip_file_name) { 'data.zip' }
   let(:zip_file_path) { File.join(download_dir, zip_file_name) }
-  let(:crdownload_file) { "#{zip_file_path}.crdownload" }
+  let(:zip_crdownload_file) { "#{zip_file_path}.crdownload" }
   let(:crdownload_files) { Dir.glob(File.join(download_dir, '*.crdownload')) }
+  let(:all_files) { crdownload_files + [zip_file_path] }
 
   before do
-    clear_download_files
-    visit 'catalog/berkeley-s7038h'
+    rm_files(all_files)
+    # visit 'catalog/berkeley-s7038h'
+    visit_public_record
   end
 
   after(:each) do
-    clear_download_files
-    Capybara.reset_sessions!
-    puts 'After callback executed -- dff'
+    # clear_download_files
+    # Capybara.reset_sessions!
+    rm_files(all_files)
+    # puts 'After callback executed -- dff'
   end
 
-  def clear_download_files
-    crdownload_files.append(zip_file_path).compact.each { |f| FileUtils.rm_f(f) }
-  end
+  # def clear_download_files
+  #   crdownload_files.append(zip_file_path).compact.each { |f| FileUtils.rm_f(f) }
+  # end
 
-  def wait_for_download(zip_file_path, timeout: 5)
-    start_time = Time.current
+  # def wait_for_download(zip_file_path, timeout: 5)
+  #   start_time = Time.current
 
-    loop do
-      elapsed_time = Time.current - start_time
-      raise "Error: Timeout waiting for downloading #{zip_file_path}" if elapsed_time > timeout
-      return true if File.exist?(zip_file_path)
+  #   loop do
+  #     elapsed_time = Time.current - start_time
+  #     raise "Error: Timeout waiting for downloading #{zip_file_path}" if elapsed_time > timeout
+  #     return true if File.exist?(zip_file_path)
 
-      sleep 1
-    end
-  rescue StandardError => e
-    Rails.logger.error e.message
-    false
-  end
+  #     sleep 1
+  #   end
+  # rescue StandardError => e
+  #   Rails.logger.error e.message
+  #   false
+  # end
 
   context 'verify original data.zip file' do
     before do
-      find('#downloads-button').click
+      click_download_button
+      # find('#downloads-button').click
     end
     it 'click link to download original source data zip file' do
       find_link('Original Shapefile').click
@@ -53,8 +57,8 @@ def wait_for_download(zip_file_path, timeout: 5)
           expect(file_names).to include('SanBenito_Intersections_2016.shp'), 'Error: SanBenito_Intersections_2016.shp not found in data.zip'
         end
       else
-        expect(File.exist?(crdownload_file)).to be_truthy, "Error: Download not completed and incompleted data.zip.crdownload file found: #{crdownload_file}"
-        expect(File.size(crdownload_file)).to be > 130_000, 'Error: Incompleted data.zip.crdownload file size <= 130000'
+        expect(File.exist?(zip_crdownload_file)).to be_truthy, "Error: Download not completed and incompleted data.zip.crdownload file found: #{zip_crdownload_file}"
+        expect(File.size(zip_crdownload_file)).to be > 130_000, 'Error: Incompleted data.zip.crdownload file size <= 130000'
       end
     end
   end

spec/features/export_geofile_spec.rb

@@ -8,8 +8,10 @@
 
   before do
     FileUtils.mkdir_p(download_dir)
-    visit 'catalog/berkeley-s7038h'
-    find('#downloads-button').click
+    visit_public_record
+    click_download_button
+    # visit 'catalog/berkeley-s7038h'
+    # find('#downloads-button').click
   end
 
   # after(:each) do

spec/rails_helper.rb

@@ -9,6 +9,7 @@
 require 'capybara/rspec'
 require 'selenium-webdriver'
 require 'socket'
+require_relative 'support/common_helpers'
 
 Capybara.register_driver(:remote_chrome) do |app|
   # chrome_args = %w[
@@ -102,6 +103,7 @@
 Capybara.run_server = false
 
 RSpec.configure do |config|
+  config.include CommonHelpers
   config.before(:each, type: :system) do
     driven_by :remote_chrome
   end

spec/support/common_helpers.rb

@@ -0,0 +1,40 @@
+module CommonHelpers
+  def visit_public_record
+    visit 'catalog/berkeley-s7038h'
+  end
+
+  def visit_restricted_record
+    visit '/catalog/berkeley-s7b12n'
+  end
+
+  def click_download_button
+    find('#downloads-button').click
+  end
+
+  def rm_files(file_paths)
+    file_paths.compact.each { |f| FileUtils.rm_f(f) }
+    Capybara.reset_sessions!
+  end
+
+  def wait_for_download(zip_file_path, timeout: 5)
+    start_time = Time.current
+
+    loop do
+      elapsed_time = Time.current - start_time
+      raise "Error: Timeout waiting for downloading #{zip_file_path}" if elapsed_time > timeout
+      return true if File.exist?(zip_file_path)
+
+      sleep 1
+    end
+  rescue StandardError => e
+    Rails.logger.error e.message
+    false
+  end
+
+  def decoded_url(url)
+    uri = URI.parse(url)
+    decoded_query = URI.decode_www_form_component(uri.query)
+    URI.decode_www_form_component("#{uri.path}?#{decoded_query}")
+  end
+
+end

spec/system/restricted_access_spec.rb

@@ -4,14 +4,15 @@
   let(:app_hostname) { IPSocket.getaddress(Socket.gethostname) }
   let(:cas_url) { "/cas/login?service=http://#{app_hostname}:3000/users/auth/calnet/callback?url=http://#{app_hostname}:3000/catalog/berkeley-s7b12n" }
   before do
-    visit '/catalog/berkeley-s7b12n'
+    visit_restricted_record
+    # visit '/catalog/berkeley-s7b12n'
   end
 
-  def decoded_url(url)
-    uri = URI.parse(url)
-    decoded_query = URI.decode_www_form_component(uri.query)
-    URI.decode_www_form_component("#{uri.path}?#{decoded_query}")
-  end
+  # def decoded_url(url)
+  #   uri = URI.parse(url)
+  #   decoded_query = URI.decode_www_form_component(uri.query)
+  #   URI.decode_www_form_component("#{uri.path}?#{decoded_query}")
+  # end
 
   it 'display login to view and download link' do
     expect(page).to have_link('Login to View and Download')