clean up

Author: yzhoubk

docker-compose.yml

@@ -46,8 +46,9 @@ services:
   selenium:
     image: selenium/standalone-chrome
     # image: selenium/standalone-chrome:4.10.0
-    # environment:
-    #   - SE_ENABLE_TRACING=false
+    environment:
+      # - SE_OTEL_SERVICE_NAME="selenium-standalone"
+      # - SE_ENABLE_TRACING=false
     ports:
       - 4444:4444
       - 7900:7900
@@ -65,3 +66,4 @@ volumes:
 
     #https://github.com/SeleniumHQ/docker-selenium/issues/2423
     #https://github.com/SeleniumHQ/docker-selenium?tab=readme-ov-file#standalone
+    #https://www.selenium.dev/blog/2023/headless-is-going-away/

spec/features/download_zipfile_spec.rb

@@ -6,6 +6,7 @@
   let(:download_dir) { '/home/seluser/Downloads/' }
   let(:zip_file_name) { 'data.zip' }
   let(:zip_file_path) { File.join(download_dir, zip_file_name) }
+  let(:crdownload_file) { "#{zip_file_path}.crdownload" }
   let(:crdownload_files) { Dir.glob(File.join(download_dir, '*.crdownload')) }
 
   before do
@@ -53,15 +54,14 @@ def wait_for_zip_download(zip_file_path, timeout: 600)
     end
     it 'click link to download original source data zip file' do
       find_link('Original Shapefile').click
-      sleep 5
+      # sleep 5
 
       # wait = Selenium::WebDriver::Wait.new(timeout: 10)
       # wait.until do
       #   !File.exist?(crdownload_file) && File.exist?(zip_file_path)
       # end
       wait_for_zip_download(zip_file_path, timeout: 30)
       expect(File.exist?(zip_file_path)).to be_truthy, "Expected source data zip file not found: #{zip_file_path}"
-
     end
 
     # it 'Source data zip file includes ' do

spec/support/shared_examples/link_spec.rb

@@ -19,13 +19,14 @@
 
 end
 
-RSpec.shared_examples 'export geofile' do |file_name, link_name|
+RSpec.shared_examples 'export geofile to local' do |file_name, link_name|
   let(:download_dir) { '/opt/app/tmp/cache/downloads' }
   let(:export_file_path) { File.join(download_dir, file_name) }
 
   before do
     # FileUtils.rm_f(shapefile_zip_file_path)
-    Dir.mkdir(download_dir) unless File.exist?(download_dir)
+    FileUtils.mkdir_p(download_dir)
+    # Dir.mkdir(download_dir) unless File.exist?(download_dir)
     # FileUtils.rm_f(shapefile_zip_file_path)
     # FileUtils.mkdir_p(download_dir)
     visit 'catalog/berkeley-s7038h'
@@ -37,10 +38,10 @@
     FileUtils.rm_f(export_file_path)
   end
 
-  it "export geofle #{file_name}" do
+  it "export geofle: #{file_name}" do
     find_link(link_name).click
     sleep 5
-    expect(File.exist?(export_file_path)).to be_truthy, "Expected source data zip file not found: #{export_file_path}"
+    expect(File.exist?(export_file_path)).to be_truthy, "Expected no exported geofile not found: #{export_file_path}"
   end
 
 end