-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaking: Colors to Chalk based #5
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 2 2
Lines 28 38 +10
Branches 3 7 +4
=====================================
+ Hits 28 38 +10
Continue to review full report at Codecov.
|
/reminder Rebasing this branch with |
Bumps [husky](https://github.com/typicode/husky) from 1.1.4 to 1.2.0. - [Release notes](https://github.com/typicode/husky/releases) - [Changelog](https://github.com/typicode/husky/blob/master/CHANGELOG.md) - [Commits](typicode/husky@v1.1.4...v1.2.0) Signed-off-by: dependabot[bot] <support@dependabot.com>
Changed the `colors` based codebase to a `chalk` one with some colour changes (out -> cyan without bold, warn -> orange); added a `getTheme` function while removing the `theme` script BREAKING CHANGE: No longer accept `colors` specific styles in `extend()` (e.g: "grey", "rainbow", "zebra", "america", "trap" and "random") but accept more choices. Some colours could be slightly different (so that could break tests relying on those). fix #2
Updated the documentation and re-added `bold` to `info()` (so this is no longer a **breaking** change for `info()` _only_)
Testing if `chalk` is enabled on TravisCI or if the fail is caused by something else (while working locally).
Updated the pre-commit hook according to the new way of doing it.
Reset the _package.json_ and the package lock
Attempt at fixing [this issue](https://github.com/chalk/chalk/issues/307) with what @nazrhyn suggested. re #2
Changed `npm test` to run `jest --color` instead of `jest --color=always`, removed the `chalk.colour` forcer in _index.js_ and tweaked a test case. re #2
Refactored duplicated block of lines flagged in Codacy
Made the `chalk` colour forcing unconditional and as complex as it needs to be (for now).
Refactored a new set of duplicated block (3 lines).
Reset the _package.json_ and the package lock
Changed `npm test` to run `jest --color` instead of `jest --color=always`, removed the `chalk.colour` forcer in _index.js_ and tweaked a test case. re #2
Made the `chalk` colour forcing unconditional and as complex as it needs to be (for now).
Removed the duplicated variable declaration that stayed after a merge conflict.
Added logs for successes (`succ`) which uses the previous colour of `info` which now uses bright blue.
Re-applied pre-rebase changes.
And fixed the package lock.
Refactored most test cases and fixed the 3 that were broken.
Added symbolic versions accessible using `./symbols` which only changes `info`, `error`, `warn`, `quest` and `succ`. `./index` was also refactored to take advantage of the common code with `./symbols` while making sure the theme was just as accessible within the package.
`extend()` now properly rejects undefined values which in the past let functions (cf. `harmless(...)` in the test suites) pass as "undefined".
As suggested by @cotsog on the TravisCI ticket, this should allow the terminal to use enough colours. re chalk/supports-color#92
Try with --color=16m
Upgrade
NewDocsFix
BuildUpdateContributorsdependabot-support, Berkmann18, dependabot[bot] Commit-Lint commandsYou can trigger Commit-Lint actions by commenting on this PR:
|
This is way too behind and I have no energy or patience to sort this out. |
Checklist
Changes
This PR implements:
Details
What does this PR implements exactly?
It implements the same things but using
chalk
instead ofcolors
.What issues does this resolve?
Fixes #2