Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking: Colors to Chalk based #5

Closed
wants to merge 88 commits into from
Closed

Breaking: Colors to Chalk based #5

wants to merge 88 commits into from

Conversation

Berkmann18
Copy link
Owner

Checklist

  • The PR follows the guidelines
  • Passes all the tests (including added/updated ones)
  • Contains a valid documentation
  • It's not a duplicate from another PR

Changes

This PR implements:

  • Bugfix
  • Feature
  • Refactoring
  • Documentation/wiki/tutorial update
  • Code style update
  • Build related change
  • Other, please specify:

Details

What does this PR implements exactly?
It implements the same things but using chalk instead of colors.

What issues does this resolve?

Fixes #2

@Berkmann18 Berkmann18 self-assigned this Nov 5, 2018
@Berkmann18 Berkmann18 added this to the 1.3.0 or 2.0.0 milestone Nov 5, 2018
@codecov
Copy link

codecov bot commented Nov 5, 2018

Codecov Report

Merging #5 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master     #5   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          28     38   +10     
  Branches        3      7    +4     
=====================================
+ Hits           28     38   +10
Impacted Files Coverage Δ
src/lib.js 100% <100%> (ø)
index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9daf3c...1a62a2f. Read the comment docs.

@Berkmann18
Copy link
Owner Author

/reminder Rebasing this branch with master regarding the commits that fix #7 (i.e. changes in index.js).

Bumps [husky](https://github.com/typicode/husky) from 1.1.4 to 1.2.0.
- [Release notes](https://github.com/typicode/husky/releases)
- [Changelog](https://github.com/typicode/husky/blob/master/CHANGELOG.md)
- [Commits](typicode/husky@v1.1.4...v1.2.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
Changed the `colors` based codebase to a `chalk` one with some colour changes (out -> cyan without
bold, warn -> orange); added a `getTheme` function while removing the `theme` script

BREAKING CHANGE: No longer accept `colors` specific styles in `extend()` (e.g: "grey", "rainbow",
"zebra", "america", "trap" and "random") but accept more choices. Some colours could be slightly
different (so that could break tests relying on those).

fix #2
Updated the documentation and re-added `bold` to `info()` (so this is no longer a **breaking**
change for `info()` _only_)
Testing if `chalk` is enabled on TravisCI or if the fail is caused by something else (while working
locally).
Updated the pre-commit hook according to the new way of doing it.
Reset the _package.json_  and the package lock
Attempt at fixing [this issue](https://github.com/chalk/chalk/issues/307) with what @nazrhyn
suggested.

re #2
Changed `npm test` to run `jest --color` instead of `jest --color=always`, removed the
`chalk.colour` forcer in _index.js_ and tweaked a test case.

re #2
Refactored duplicated block of lines flagged in Codacy
Made the `chalk` colour forcing unconditional and as complex as it needs to be (for now).
Refactored a new set of duplicated block (3 lines).
Berkmann18 and others added 26 commits December 11, 2018 09:43
Reset the _package.json_  and the package lock
Changed `npm test` to run `jest --color` instead of `jest --color=always`, removed the
`chalk.colour` forcer in _index.js_ and tweaked a test case.

re #2
Made the `chalk` colour forcing unconditional and as complex as it needs to be (for now).
Removed the duplicated variable declaration that stayed after a merge conflict.
Added logs for successes (`succ`) which uses the previous colour of `info` which now uses bright
blue.
Re-applied pre-rebase changes.
And fixed the package lock.
Refactored most test cases and fixed the 3 that were broken.
Added symbolic versions accessible using `./symbols` which only changes `info`, `error`, `warn`,
`quest` and `succ`. `./index` was also refactored to take advantage of the common code with
`./symbols` while making sure the theme was just as accessible within the package.
`extend()` now properly rejects undefined values which in the past let functions (cf.
`harmless(...)` in the test suites) pass as "undefined".
As suggested by @cotsog on the TravisCI ticket, this should allow the terminal to use enough
colours.

re chalk/supports-color#92
@commit-lint
Copy link

commit-lint bot commented May 26, 2023

Upgrade

  • Bump husky from 1.1.4 to 1.2.0 (b57b2a6)
  • Bump semantic-release from 15.12.3 to 15.12.4 (eb62bc0)
  • Updated some dependencies (9294658)

New

  • Implementation with chalk (b922277)
  • Implementation with chalk (48e775f)

Docs

Fix

  • Test: Chalk enabled on Travis? (fe011f7)
  • index: "Force" enabled chalk (a05e937)
  • Applied fixes from 473a945 (a4ea23f)
  • Test: Fixed package file reading issue (75dbdaa)
  • Test: Fix attempt on with Jest (5e888b3)
  • Test: Removed duplicated tests (600f2ec)
  • Test: Changed the chalk colour forcer (972e0af)
  • Test: Removed a new duplication (73d9811)
  • Removed post-merge duplication (a5bb744)
  • Test: Chalk enabled on Travis? (ea12390)
  • index: "Force" enabled chalk (e10f576)
  • Applied fixes from 473a945 (2fa8f47)
  • Test: Fixed package file reading issue (67fb68d)
  • Test: Fix attempt on with Jest (bc264d8)
  • Test: Removed duplicated tests (707fe47)
  • Test: Changed the chalk colour forcer (fa17131)
  • Test: Removed a new duplication (d01fda0)

Build

  • Husky: Updated the husky config (a6eaf71)
  • Husky: Updated the husky config (47c91ae)

Update

Contributors

dependabot-support, Berkmann18, dependabot[bot]

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@Berkmann18
Copy link
Owner Author

Berkmann18 commented May 26, 2023

This is way too behind and I have no energy or patience to sort this out.

@Berkmann18 Berkmann18 closed this May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switching to a better colour provider
3 participants