Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Indentation breaks annotations #7749

Closed
mikstew opened this issue Jan 13, 2025 · 6 comments
Closed

[Bug]: Indentation breaks annotations #7749

mikstew opened this issue Jan 13, 2025 · 6 comments
Labels
bug Something isn't working

Comments

@mikstew
Copy link
Contributor

mikstew commented Jan 13, 2025

What happened?

This PR added an indentation of 1 space to the file, which breaks template from properly adding the annotations defined in the values.yaml.

Relevant log output

No response

Are you a ML Ops Team?

No

What LiteLLM version are you on ?

v1.58.0

Twitter / LinkedIn details

No response

@mikstew mikstew added the bug Something isn't working label Jan 13, 2025
@ishaan-jaff
Copy link
Contributor

that's odd it worked for me on Argo CD, is there a test you'd recommend we add here to prevent this from re occurring @mikstew

@mikstew
Copy link
Contributor Author

mikstew commented Jan 13, 2025

I found an existing PR by @Hexoplon that addresses the issue.

@mikstew
Copy link
Contributor Author

mikstew commented Jan 13, 2025

@ishaan-jaff Did your test include a migrationJob.annotation? Everything else seems to work fine because the space was added to every other line. It only broke the annotations because that dynamically adds the annotations in at an indentation of 8.

@ishaan-jaff
Copy link
Contributor

fixed on #7652

@ishaan-jaff
Copy link
Contributor

working on adding better testing too

@ishaan-jaff
Copy link
Contributor

Added testing for helm here @mikstew #7789

let me know if you have any recs on how we can test better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants