Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contracts: weight dedution bug #2499

Open
credence0x opened this issue Dec 14, 2024 · 1 comment
Open

contracts: weight dedution bug #2499

credence0x opened this issue Dec 14, 2024 · 1 comment
Assignees
Labels
prio: high high priority

Comments

@credence0x
Copy link
Collaborator

  • we don't remove weight somewhere after removing resources

https://discord.com/channels/884211910222970891/1314137669223321650/1317446942841765933

@bob0005
Copy link
Collaborator

bob0005 commented Dec 15, 2024

@credence0x It seems like we forgot to update the army's weight cap on early battle leave:
https://github.com/BibliothecaDAO/eternum/blob/next/contracts/src/systems/combat/contracts/battle_systems.cairo#L679-L702

@bob0005 bob0005 self-assigned this Jan 22, 2025
@bob0005 bob0005 added the prio: high high priority label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio: high high priority
Projects
None yet
Development

No branches or pull requests

2 participants