Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harvester updates for mosquito sample classes #441

Open
sunray1 opened this issue Apr 16, 2024 · 3 comments
Open

Harvester updates for mosquito sample classes #441

sunray1 opened this issue Apr 16, 2024 · 3 comments
Assignees
Labels
Back End Issue or feature concerning back end of the portal

Comments

@sunray1
Copy link
Collaborator

sunray1 commented Apr 16, 2024

For the mosquito sample classes, the harvester is failing to record data from the API, even though the information is available.

For Bulk Identified/DNA Extracts/Pathogen Extracts/Pinned Vouchers:

  • Check Plot/Site information - for bulk identified, there should be no plot, it should only be to site; check this for the others
  • Determination date (added recently by NEON) and identifiedBy - none of these are being pulled in even though the information is at the grandparent or the sample level depending on the class
  • Sample count - for bulk samples this is getting taken from the first grandparent instead of the sample itself, for pinned vouchers, this is likely hard coded as 1
  • Life Stage and reproductive condition - for single samples this exists at the sample level but is not getting recorded
@sunray1 sunray1 added the Back End Issue or feature concerning back end of the portal label Apr 16, 2024
@sunray1 sunray1 self-assigned this Apr 16, 2024
@sunray1
Copy link
Collaborator Author

sunray1 commented Apr 16, 2024

Related to #325

@kyule
Copy link
Member

kyule commented May 29, 2024

I did some additional digging here 5/28/24

If we were to "uncomment out" //if(strpos($tableName,'identification')) continue; we would be able to correctly harvest the collector for pinned mosquitos and DNA samples as the API is always providing "National Ecological Observatory Network..." for these samples (likely is because of how the expert identifiers are returning data). However, uncommenting out that line prevents harvesting of other fields that do rely on that table. It would be better if we could get NEON to not include that in the API.

The sorting table is needed in order to get the determination dates and references but relying on info that far up the heirarchy leads to incorrect plot, individual count, etc. Commenting out the line that causes us to skip the barcoding table. Collection date is provided in the barcoding table but not the pinned table so you need to go up to the sorting table for the pinned individual but not its child sample :/

@kyule
Copy link
Member

kyule commented May 29, 2024

Currently the line to skip the 'identifications' table is commented out, but the line to skip the 'barcoding' table is active. Sample classes like pinned and DNA sample, are therefore able to get the correct taxon for the sample but do not see the identifiedBy, identificationResources, and identificationDate fields because those are located in the barcoding table, etc. They get the taxon and say the determiner, etc, is unknown. Although they would be able to see this information in the parent sample, they already have an identificaiton (albeit incomplete) from the sample itself so $harvestIdentifications is false and the parent sample identification is not used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Back End Issue or feature concerning back end of the portal
Projects
None yet
Development

No branches or pull requests

2 participants