Maint/async engine 3 #1695
Draft
Maint/async engine 3 #1695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickeZ
force-pushed
the
maint/async-engine-3
branch
11 times, most recently
from
91fe8e7 to
7e7eba6
Compare
NickeZ
force-pushed
the
maint/async-engine-3
branch
2 times, most recently
from
831d121 to
ff1ac2f
Compare
Instead of relying on the caller to not modify the buffer a copy is made to static memory. This enables the caller to use a stack allocated buffer.
NickeZ
force-pushed
the
maint/async-engine-3
branch
2 times, most recently
from
440fc7d to
1cf82ff
Compare
ports orientation screen and delay to show that waking works
NickeZ
force-pushed
the
maint/async-engine-3
branch
from
1cf82ff to
b5f6448
Compare
NickeZ
commented
Nov 27, 2025
|
|
||
| #[cfg_attr(feature = "c-unit-testing", allow(unused))] | ||
| fn main_loop() -> ! { | ||
| static ORIENTATION_CHOSEN: AtomicBool = AtomicBool::new(false); |
Collaborator
Author
There was a problem hiding this comment.
instead of using an AtomicBool I think I could wrap the uart_write_queue in an Arc<Mutex<>> and put all the handling in the async function given to the executor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.