Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Layout field causing issues with testing #564

Closed
kjaymiller opened this issue Nov 6, 2024 · 0 comments · Fixed by #563
Closed

No Layout field causing issues with testing #564

kjaymiller opened this issue Nov 6, 2024 · 0 comments · Fixed by #563

Comments

@kjaymiller
Copy link
Contributor

When folks are creating blog posts, they are likely not adding all of the frontmatter content. One of the things that is commonly not added is the layout tag.

THIS IS A PROBLEM

When generating the page for testing - the site applies the default tag of article and not post. This works and the site looks mostly the same but it's missing much of the components needed to make the site load properly.

with layout defined.

<!doctype html>
<html lang="en">
  <head>
    <meta charset="UTF-8" />
    <meta name="viewport" content="width=device-width, initial-scale=1" />
    <meta
      name="description"
      content="Discover the inspiring stories of Uganda&#39;s next generation African Python developers who attended PyconUG 2024 and learn about their experiences in a vibrant tech community."
    />
    <title>Black Python Devs | Black Python Devs at PyconUG 2024</title>
    <link rel="stylesheet" href="/assets/css/style.css" />
    <link rel="stylesheet" href="/assets/css/pico.min.css" />
    <link rel="stylesheet" href="/assets/css/pico.colors.min.css" />
    <link rel="stylesheet" href="/assets/css/bpd.css" />
    <link
      rel="canonical"
      href="http://localhost:56178/2024-10-25-pycon-ug-2024/"
    />
    <link
      rel="alternate"
      type="application/rss+xml"
      title="Black Python Devs"
      href="http://localhost:56178/feed.xml"
    />
    <link
      rel="icon"
      href="https://fav.farm/%E2%9C%8A%F0%9F%8F%BE"
      type="image/svg"
    />
  </head>
</html>

without it (it goes straight to the content)

<p>Wednesday, 9th, October, 2024, was Uganda’s Independence day.</p>

I'm not sure why this is the case but the fix is an easy one.

**ensure that layout: post is on all of the blog posts.

I will fix this in an upcoming PR to get tests passing but there should be a pre-commit rule to fix this.


@kjaymiller kjaymiller linked a pull request Nov 6, 2024 that will close this issue
9 tasks
@kjaymiller kjaymiller reopened this Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant