Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve pull_request_template.md file #174

Open
kgashok opened this issue Jan 7, 2022 · 2 comments
Open

Improve pull_request_template.md file #174

kgashok opened this issue Jan 7, 2022 · 2 comments
Assignees
Labels
style coding style and conventions

Comments

@kgashok
Copy link
Collaborator

kgashok commented Jan 7, 2022

Review https://github.com/appium/appium/blob/master/.github/PULL_REQUEST_TEMPLATE.md

Discuss which parts are relevant to this project, and add/modify the current template, including moving it to /docs directory.

@Pavithratrdev

@kgashok kgashok added the style coding style and conventions label Jan 7, 2022
@Pavithratrdev
Copy link
Contributor

Sure sir, will do it

@kgashok
Copy link
Collaborator Author

kgashok commented Jan 9, 2022

Some other formats:

What does this PR do?

Fixes #<issue_number>

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
style coding style and conventions
Projects
None yet
Development

No branches or pull requests

2 participants