Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support eFeatures written in Python #27

Open
wvangeit opened this issue Sep 29, 2015 · 3 comments
Open

Support eFeatures written in Python #27

wvangeit opened this issue Sep 29, 2015 · 3 comments

Comments

@wvangeit
Copy link
Contributor

It would be handy if the eFEL would support eFeatures written by users in pure python, without requiring a C++ implementation

mgeplf added a commit to mgeplf/eFEL that referenced this issue Feb 15, 2016
* as desired in:
    BlueBrain#27
* currently only for Python
* Documentation will come as we settle on an API
@orena1
Copy link
Contributor

orena1 commented Jun 29, 2018

Hi,
Does it work? Can I use my own python written functions?
Thanks.

@wvangeit
Copy link
Contributor Author

Yes, more or less. I still need to write some documentation on how to exactly add your own features. But I think it's fairly easy to figure it out based on how this feature was implemented:
https://github.com/BlueBrain/eFEL/blob/master/efel/pyfeatures/pyfeatures.py#L91
As a general rules, when implementing a new feature try to reuse as much as possible the existing cpp features (to detect spikes etc). At some point these will be rewritten in python, but if people now start using their own implementation things might get very messy.
One caveat mentioned here:
#131
The getDistance function doesnt accept python features yet. So it wouldnt work with bluepyopt yet. Let me know if you need that urgently and I will bump it up on my priority list.

@wvangeit
Copy link
Contributor Author

wvangeit commented Jul 5, 2018

@orena1
This PR adds the python features to getDistance(): #135

This pypi version includes that code:
https://pypi.org/project/efel/3.0.12/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants