You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, one must call set_token in nmodl.yy to have information about where the token appears in the MOD file. Since, it's manual, it's rarely used, and many nodes of the initial AST don't have any token information associated with them.
For example FUNCTION and PROCEDURE blocks have their ModToken set, while NET_RECEIVE doesn't.
Instead of fixing all occurences using the current API, we could consider changing the ctors for AST nodes such that they expect the ModToken (describing the location) as their first argument, and then the additional arguments. This way the compiler will complain about any omissions.
The text was updated successfully, but these errors were encountered:
Currently, one must call
set_token
innmodl.yy
to have information about where the token appears in the MOD file. Since, it's manual, it's rarely used, and many nodes of the initial AST don't have any token information associated with them.For example FUNCTION and PROCEDURE blocks have their
ModToken
set, while NET_RECEIVE doesn't.nmodl/src/parser/nmodl.yy
Lines 1496 to 1506 in 5abff4f
Instead of fixing all occurences using the current API, we could consider changing the ctors for AST nodes such that they expect the
ModToken
(describing the location) as their first argument, and then the additional arguments. This way the compiler will complain about any omissions.The text was updated successfully, but these errors were encountered: