Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a visitor class to replace units in statements #1461

Open
JCGoran opened this issue Sep 24, 2024 · 0 comments
Open

Add a visitor class to replace units in statements #1461

JCGoran opened this issue Sep 24, 2024 · 0 comments

Comments

@JCGoran
Copy link
Contributor

JCGoran commented Sep 24, 2024

Some of the mod files (such as this one) have units directly in statements, for instance:

area1 = 2*PI*(diam/2) * 1(um)

We should add a visitor (that runs fairly early) which replaces these units with their actual numerical values since the syntax is not compatible with SymPy.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JCGoran