Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pointless macros from crout.hpp #1500

Open
1uc opened this issue Oct 7, 2024 · 0 comments
Open

Remove pointless macros from crout.hpp #1500

1uc opened this issue Oct 7, 2024 · 0 comments

Comments

@1uc
Copy link
Collaborator

1uc commented Oct 7, 2024

The naming conventions in solveCrout need fixing. y isn't a good name for a pivot vector, p is more canonical, but p is something completely different, unless it's used through the macro y_[i] (which is p[y[i]]).

The the blocks of code are completely duplicated and can be trivially be deduplicated using a sensible abstraction for y_.

The second copy of the comments is incorrect/misleading about y.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant