Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing dependencies #3

Open
ostueker opened this issue Jan 5, 2020 · 12 comments
Open

Missing dependencies #3

ostueker opened this issue Jan 5, 2020 · 12 comments

Comments

@ostueker
Copy link
Member

ostueker commented Jan 5, 2020


Initial post:

I've just had a glance over the dependencies and noticed a few where I'm not sure whether we have everything that's needed:

chemdraw-converter

Found it in @petermr 's Bitbucket account at https://bitbucket.org/petermr/chemdraw-converter and because it's a Mercurial repo, I've imported it to the BlueObelisk org.

jbabel

This maven artifact has the group-ID sea36 so hopefully @sea36 has an idea where it comes from.

Searching a bit I found a blog post from 2007 that links to a location where one can download a jar.

I'm not sure whether it's the same thing, though.

jumbo-units

Here I have no idea what it is or where to find it. 🤔

@petermr
Copy link
Contributor

petermr commented Jan 5, 2020 via email

@ostueker
Copy link
Member Author

ostueker commented Jan 5, 2020

Thanks Peter,
and I totally agree that it is worthwhile to replace some old and outdated packages with more modern and more complete and robust ones.

However right now my main aim is to get to the point where everything compiles to make sure we don't miss any critical components and that without making too many (or any) changes in the existing code base. I'd like to have the old test suite passing before starting to replace one library by another.

@ostueker
Copy link
Member Author

ostueker commented Jan 5, 2020

Ha! I just found the source code for jumbo-units and a whole list of other tools within the CML project on sourceforge.net.

There’s even the chemdraw-converter including it’s commit history. I can probably do a re-import from there.

@petermr
Copy link
Contributor

petermr commented Jan 5, 2020 via email

@ostueker
Copy link
Member Author

ostueker commented Jan 5, 2020

For the first time in probably more than 3 years, I was able to compile the jumbo-converters but not without deactivating some modules and making short dives into the source code.

I found a few more problematic dependencies:

owlapi

I can't find g:owlapi a:owlapi but the project seems to be on Maven Central these days: https://github.com/owlcs/owlapi/. Need to try our which sub-packages are needed and which version works with our code.
For now I have deactivated jumbo-converters-rdf (depends on owlapi) and jumbo-converters-reaction (needs JC-rdf).

lensfield2

I found some lensfield code on Bitbucket but that seems to be an older version (v1 not v2).
However I was able to remove the dependency from the code (mostly annotations like @LensfieldParameter ). From what I saw, their purpose was to run the jumbo-converters within the lensfield framework. My guess: not a big loss.

osra-runner (group id uk.ac.cam.ch.osra-runner)

I have deactivated jumbo-converters-graphics (depends on osra-runner) and jumbo-converters-spectrum (needs JC-graphics).
In an old osra-runner-parent POM that I found in some old maven-cache, I noticed that @sea36 seems to be the developer on this.
Sam, can you provide some more insight on what it does and whether the code-base still exists?

semsci-chemistry (group id gigadot.semsci)

This is a dependency for jumbo-converters-compchem-misc.
I believe it's also RDF-related but I haven't tried to read the code to find out what it does.

Again: no public code to be found anywhere.

@petermr
Copy link
Contributor

petermr commented Jan 5, 2020 via email

@sea36
Copy link
Contributor

sea36 commented Jan 5, 2020 via email

@petermr
Copy link
Contributor

petermr commented Jan 5, 2020 via email

@sea36
Copy link
Contributor

sea36 commented Jan 5, 2020 via email

@petermr
Copy link
Contributor

petermr commented Jan 5, 2020 via email

@ostueker
Copy link
Member Author

ostueker commented Jan 6, 2020

Hi Sam, thank you for the hints.

Interestingly I didn’t see any errors regarding the missing jbabel. So either it’s no longer needed or it’s needed by one of the modules that I had to deactivate for another reason.

The lensfield2 and osra-runner packages are Mercurial repos on Bitbucket and therefore subject to be deleted in a few months.

Sam, Peter, should we import them to this BlueObelisk org on GitHub and treat them along with the other WWMM repos?
None of them has a License.txt file in the root of the repo, nor do they define any license in the main POM. Should those be under Apache 2.0 as well?

Oliver

@petermr
Copy link
Contributor

petermr commented Jan 6, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants