Skip to content

Recent commit breaks winter cmake #59

@VoxelTek

Description

@VoxelTek

a58b98f breaks building winter. Specifically, the changes to winter/Code/binding/CMakeLists.txt.

After creating and entering a build folder, trying to run cmake .. or cmake .. -DGODOT=1 -DGODOT_GDEXTENSION_DIR="gdextension" -DGODOT_CPP_SYSTEM_HEADERS=ON throws this error:

CMake Version: 3.30.20240713-g3649110
CMake Deprecation Warning at build/_deps/json-src/CMakeLists.txt:1 (cmake_minimum_required):
  Compatibility with CMake < 3.5 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.


-- Using the multi-header code from /home/voxeltek/Documents/Applications/Adastral/winter/build/_deps/json-src/include/
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE
-- Found OpenSSL: /usr/lib/x86_64-linux-gnu/libcrypto.so (found version "3.0.13")
CMake Warning (dev) at /usr/local/share/cmake-3.30/Modules/CMakeFindDependencyMacro.cmake:76 (find_package):
  Policy CMP0167 is not set: The FindBoost module is removed.  Run "cmake
  --help-policy CMP0167" for policy details.  Use the cmake_policy command to
  set the policy and suppress this warning.

Call Stack (most recent call first):
  /usr/lib/x86_64-linux-gnu/cmake/LibtorrentRasterbar/LibtorrentRasterbarConfig.cmake:26 (find_dependency)
  Code/torrent/CMakeLists.txt:3 (find_package)
This warning is for project developers.  Use -Wno-dev to suppress it.

-- Found Boost: /usr/lib/x86_64-linux-gnu/cmake/Boost-1.83.0/BoostConfig.cmake (found version "1.83.0")
-- Found Python3: /usr/bin/python3.12 (found suitable version "3.12.3", minimum required is "3.4") found components: Interpreter
-- Found PkgConfig: /usr/bin/pkg-config (found version "1.8.1")
-- Checking for module 'libnotify'
--   Found libnotify, version 0.8.3
-- Checking for module 'glib-2.0'
--   Found glib-2.0, version 2.80.0
-- Checking for module 'gdk-pixbuf-2.0'
--   Found gdk-pixbuf-2.0, version 2.42.10
Setup custom build type: 
CMake Error at Code/binding/CMakeLists.txt:45 (string):
  string no output variable specified


CMake Error at Code/binding/CMakeLists.txt:46 (string):
  string no output variable specified


-- Configuring incomplete, errors occurred!

Reverting this file to how it was in the previous commit fixes the issue and allows winter to be compiled.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions