Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Breakdown Prediction for Stats too Low #159

Closed
Ferrariic opened this issue Aug 7, 2022 · 4 comments · May be fixed by #148
Closed

Remove Breakdown Prediction for Stats too Low #159

Ferrariic opened this issue Aug 7, 2022 · 4 comments · May be fixed by #148

Comments

@Ferrariic
Copy link
Member

Ferrariic commented Aug 7, 2022 •
edited
Loading

We'd like to do the following:

In cases of Stats too low (ex. an account below 2m xp) we would remove the breakdown predictions, as they're not entirely relevant.
Let us know if you think this would be a good change ✅ , or to keep the current system ❌.

✅ 55
❌ 5

This can be a default off config for stats too low, and allow users to toggle it on -- if they'd like to.
@Cyborger1
Copy link
Collaborator

Cyborger1 commented Aug 7, 2022 •
edited
Loading

I feel this should be on the API side no? The API should not return a prediction breakdown for these people.

I think that's how it was before no? If the breakdown map is null it won't add the box.

@Ferrariic
Copy link
Member Author

There's a discussion to have it still send it on the API side, but have a yes/no toggle on the plugin side, so we're looking at that atm.

@Cyborger1
Copy link
Collaborator

We'd either need to have an extra field in the data sent to the plugin (I'm not a fan of having to look for a hard coded string 'stats too low') or have a parameter on the route to send the breakdown or not when that condition happens.

@Ferrariic Ferrariic linked a pull request Aug 8, 2022 that will close this issue
Hide Prediction Breakdowns By Default #148
Open
@Ferrariic
Copy link
Member Author

Should be solved on API side

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Hide Prediction Breakdowns By Default ThorntonMatthewD/bot-detector
2 participants
@Ferrariic @Cyborger1