From 98d7ba02b199c4e7eb56c1408b35e375355f5dfb Mon Sep 17 00:00:00 2001 From: echo Date: Mon, 4 Dec 2023 14:54:16 -0800 Subject: [PATCH] SDK-2093 remove old set identity tests, these are covered in public API tests or underlying preferencehelper tests --- .../Branch-SDK-Tests/BranchSetIdentityTests.m | 69 ------------------- .../Branch-TestBed.xcodeproj/project.pbxproj | 4 -- 2 files changed, 73 deletions(-) delete mode 100644 Branch-TestBed/Branch-SDK-Tests/BranchSetIdentityTests.m diff --git a/Branch-TestBed/Branch-SDK-Tests/BranchSetIdentityTests.m b/Branch-TestBed/Branch-SDK-Tests/BranchSetIdentityTests.m deleted file mode 100644 index 98ec8cf4c..000000000 --- a/Branch-TestBed/Branch-SDK-Tests/BranchSetIdentityTests.m +++ /dev/null @@ -1,69 +0,0 @@ -// -// BranchSetIdentityRequestTests.m -// Branch-TestBed -// -// Created by Graham Mueller on 6/10/15. -// Copyright (c) 2015 Branch Metrics. All rights reserved. -// - -#import "BNCTestCase.h" -#import "BranchConstants.h" -#import "BNCPreferenceHelper.h" -#import "Branch.h" -//#import -// -//static NSString * const IDENTITY_TEST_USER_ID = @"foo_id"; -// -//@interface BranchSetIdentityTests : BNCTestCase -//@end -// -//@implementation BranchSetIdentityTests -// -//#pragma mark - setIdentity Tests -//- (void)testSetIdentityWithCallback { -// Branch *branch = [Branch getInstance]; -// [branch logoutWithCallback:^(BOOL changed, NSError * _Nullable error) { -// BNCPreferenceHelper *preferenceHelper = [BNCPreferenceHelper sharedInstance]; -// -// XCTestExpectation *expectation = [self expectationWithDescription:@"setIdentity callback is called"]; -// -// [branch setIdentity:@"testUserIdWithCallback" withCallback:^(NSDictionary *params, NSError *error) { -// XCTAssertEqualObjects(@"testUserIdWithCallback", preferenceHelper.userIdentity); -// [expectation fulfill]; -// }]; -// -// [self waitForExpectationsWithTimeout:5 handler:nil]; -// }]; -//} -// -//- (void)testSetIdentityWithNilUserId { -// Branch *branch = [Branch getInstance]; -// [branch logoutWithCallback:^(BOOL changed, NSError * _Nullable error) { -// BNCPreferenceHelper *preferenceHelper = [BNCPreferenceHelper sharedInstance]; -// -// XCTestExpectation *expectation = [self expectationWithDescription:@"setIdentityWithNil callback is called"]; -// -// [branch setIdentity:nil withCallback:^(NSDictionary *params, NSError *error) { -// XCTAssertNil(preferenceHelper.userIdentity); -// [expectation fulfill]; -// }]; -// -// [self waitForExpectationsWithTimeout:5 handler:nil]; -// }]; -//} -// -//- (void)testSetIdentityWithUserId { -// Branch *branch = [Branch getInstance]; -// [branch logoutWithCallback:^(BOOL changed, NSError * _Nullable error) { -// BNCPreferenceHelper *preferenceHelper = [BNCPreferenceHelper sharedInstance]; -// -// NSString *testUserId = @"testUserId"; -// [branch setIdentity:testUserId withCallback:nil]; -// -// XCTAssertEqualObjects(@"testUserId", preferenceHelper.userIdentity); -// }]; -//} -// -// -// -//@end diff --git a/Branch-TestBed/Branch-TestBed.xcodeproj/project.pbxproj b/Branch-TestBed/Branch-TestBed.xcodeproj/project.pbxproj index 7b18c57f6..7e218f30a 100644 --- a/Branch-TestBed/Branch-TestBed.xcodeproj/project.pbxproj +++ b/Branch-TestBed/Branch-TestBed.xcodeproj/project.pbxproj @@ -33,7 +33,6 @@ 4683F0761B20A73F00A432E7 /* AppDelegate.m in Sources */ = {isa = PBXBuildFile; fileRef = 670016731940F51400A9E103 /* AppDelegate.m */; }; 46DC406E1B2A328900D2D203 /* AdSupport.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 67BBCF271A69E49A009C7DAE /* AdSupport.framework */; }; 4AB16368239E3A2700D42931 /* DispatchToIsolationQueueTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 4AB16367239E3A2700D42931 /* DispatchToIsolationQueueTests.m */; }; - 4D1683A62098C902008819E3 /* BranchSetIdentityTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 4D16837B2098C901008819E3 /* BranchSetIdentityTests.m */; }; 4D1683A82098C902008819E3 /* BNCServerRequestQueueOldTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 4D16837D2098C901008819E3 /* BNCServerRequestQueueOldTests.m */; }; 4D1683AA2098C902008819E3 /* BranchOpenRequestTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 4D16837F2098C901008819E3 /* BranchOpenRequestTests.m */; }; 4D1683AC2098C902008819E3 /* BranchInstallRequestTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 4D1683822098C901008819E3 /* BranchInstallRequestTests.m */; }; @@ -325,7 +324,6 @@ 466D5A101B5991E3009DB845 /* BNCContentDiscoveryManager.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = BNCContentDiscoveryManager.m; sourceTree = ""; }; 46DBB42F1B335A9B00642FC8 /* BranchDeepLinkingController.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = BranchDeepLinkingController.h; sourceTree = ""; }; 4AB16367239E3A2700D42931 /* DispatchToIsolationQueueTests.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = DispatchToIsolationQueueTests.m; sourceTree = ""; }; - 4D16837B2098C901008819E3 /* BranchSetIdentityTests.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = BranchSetIdentityTests.m; sourceTree = ""; }; 4D16837D2098C901008819E3 /* BNCServerRequestQueueOldTests.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = BNCServerRequestQueueOldTests.m; sourceTree = ""; }; 4D16837E2098C901008819E3 /* BNCServerInterface.Test.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = BNCServerInterface.Test.m; sourceTree = ""; }; 4D16837F2098C901008819E3 /* BranchOpenRequestTests.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = BranchOpenRequestTests.m; sourceTree = ""; }; @@ -680,7 +678,6 @@ C10F393927A0872800BF5D36 /* BranchPluginSupportTests.m */, C12320B42808DB90007771C0 /* BranchQRCodeTests.m */, 4D1683862098C901008819E3 /* BranchSDKFunctionalityTests.m */, - 4D16837B2098C901008819E3 /* BranchSetIdentityTests.m */, C10C61A9282481FB00761D7E /* BranchShareLinkTests.m */, 4D1683962098C901008819E3 /* BranchUniversalObjectTests.m */, 4AB16367239E3A2700D42931 /* DispatchToIsolationQueueTests.m */, @@ -1434,7 +1431,6 @@ 5F892EC5236116CD0023AEC1 /* NSErrorBranchTests.m in Sources */, 4D1683AA2098C902008819E3 /* BranchOpenRequestTests.m in Sources */, 4D1683A82098C902008819E3 /* BNCServerRequestQueueOldTests.m in Sources */, - 4D1683A62098C902008819E3 /* BranchSetIdentityTests.m in Sources */, 4D1683B62098C902008819E3 /* BNCURLFilterTests.m in Sources */, C10C61AA282481FB00761D7E /* BranchShareLinkTests.m in Sources */, 5F437E40237E1A560052064B /* BNCDeviceSystemTests.m in Sources */,