-
Notifications
You must be signed in to change notification settings - Fork 474
Closed
Labels
Milestone
Description
The HashDetector already resizes the input to a specific size, so we should avoid downscaling the input for this particular detector. This might involve changing the SceneDetector interface so that detectors can choose if they want a pre-scaled version of the frame, or if they need to work with the original.
The perceptual hash detector is a bit of a special case, since it requires that the input be a square for the DCT. Right now the image is scaled twice, which is not ideal, especially if the downscaled version is smaller than the DCT size (since we're throwing away information).
This doesn't matter too much for accuracy since we apply a low-pass filter on the result, but it is something we should avoid doing for the pipeline.