Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to disable notifications for STI class #26

Open
seancdavis opened this issue Jan 16, 2017 · 1 comment
Open

Option to disable notifications for STI class #26

seancdavis opened this issue Jan 16, 2017 · 1 comment

Comments

@seancdavis
Copy link
Contributor

Consider the case where you have a handful of model inheriting from one parent model. If the children all can share notifications, then it makes sense to set the notification on the parent. This still applies in the case where perhaps one child may differ from the rest. It would be great to be able to disable notifications for that child.

@digerata
Copy link
Member

digerata commented Feb 3, 2017

My 2 cents:

It might be safer to disable all parent notifications as opposed singling out individual parent notifications to disable. Otherwise the definition of what happens is spread across multiple classes. (Which, is a core tenant to object oriented programming, I get that...but still)

If we go that route of disabling individual parent notifications, the syntax should be as clear and concise as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants