Not working on any file ext: "Cannot read property 'begin' of undefined"

[Acumane]

Receive error "Cannot read property 'begin' of undefined" in all the file types I've tried (.cpp, .txt., .json, .yml, .md)

VSCode v1.63.2
Toggle Quotes v0.3.6

[Dunky13]

.js file don't work either

[jeremychone]

Super long delay. I will look at this.
Somehow, I cannot reproduce it. But I will definitely look at it.

[Dunky13]

For me it was because I selected the text to change, you only need the cursor within the string/quotes to work

[jeremychone]

Ha ok, yes more a Documentation issue. I will try do do a animated gif.

[Acumane]

For me it was because I expected it to wrap around the current word (or a selection) when none exists yet:

Is this a feature you'd entertain @jeremychone?

[jeremychone]

First, awesome animated gif. Thanks for doing it.

Now, that's something else. I need to think about this.

Today, by design, the selection becomes the "exclusion" part, and the start/end of the selection is used to find the first quote.

Now, your use case is interesting. If nothing is found in the respective lines, then the selection becomes the bounding box in a way and the first cycle starts, but then, you cannot get back to the initial state.

So, at the end, it might feel weird and buggy.

Let me thinks about this.

[Acumane]

If nothing is found in the respective lines, then the selection becomes the bounding box in a way

Also, if no selection is made, whitespace nearest to our cursor should inform the bounding box size—much like iw in Vim

...and the first cycle starts, but then, you cannot get back to the initial state.

Good point! Two ideas:

1. Use Shift+Ctrl+'to cycle backwards & arrive at initial state
2. Add a "no character" option under "togglequotes.chars" (perhaps "") so that one could cycle to what is effectively the initial state (nothing).

Something to this effect feels necessary for an extension titled "Toggle Quotes" in which toggling isn't possible. Otherwise I'd probably call it "Cycle Quotes" instead.

Thanks for doing it.

Thank you for your FOSS! I enjoy giving helpful feedback... least I can do, especially when my requests demand your time & energy.

[jeremychone]

Thanks for the feedback. The trick, is the important design point is that this is a stateless plugin. meaning, it does not remember the n-1 state or n-m or original state, only the current state and can deduct the next one.

So, I need to think about it to make sure those kind of things do brake this important design point.

[macCesar]

As of today, it throws this error when selecting a block of text AND the quotes to change:

Cannot read properties of null (reading 'begin').

If I select only the text, the quotes cycle through perfectly!

[jeremychone]

Ah yes, this message Cannot read properties of undefined (reading 'begin') occurs when it can't find a pair in the current line.

However, if you have text like Hello "some text ][ here" world and then have the toggle quote at the cursor, it should work, right?

I should update the error message to be clearer.

[jwalkerinterpres]

If I have the line:

{ has: page.locator(`span:has-text("")`) }

and I select the quote:

{ has: page.locator(`span:has-text("") |`| ) }

I get "Cannot read properties of undefined (reading 'begin')".

If I put the cursor after the quote:

{ has: page.locator(`span:has-text("") `| ) }

I also get "Cannot read properties of undefined (reading 'begin')"

If I put the cursor before the quote:

{ has: page.locator(`span:has-text("") |` ) }

it works ...

{ has: page.locator("span:has-text("${source}")") }

... except, if I do it again, it changes the quote inside the string (instead of the matching quote at the start):

{ has: page.locator("span:has-text("${source}')') }