Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SBUS_Ready() forever true #24

Open
ericlangel opened this issue Sep 2, 2020 · 4 comments
Open

SBUS_Ready() forever true #24

ericlangel opened this issue Sep 2, 2020 · 4 comments
Labels
bug Something isn't working Done Done but not commited
Milestone

Comments

@ericlangel
Copy link
Collaborator

If the SBUS(2) Signal is broken (wire broken, disconnected or receiver unpowered) the SBUS_Ready() function would return true forever.

There should be a reset of sbus_ready and telemetry_ready.

The Functions will be false until a new SBUS(2) Frame is received

@ericlangel
Copy link
Collaborator Author

same for SBUS2_Ready()

@ericlangel
Copy link
Collaborator Author

done

@ericlangel ericlangel reopened this Dec 4, 2020
@ericlangel
Copy link
Collaborator Author

issue reopen because:

SBUS2_Ready() also reset SBUS_Ready() -> this should be handled somehow

an always resetting isn't a good solution
sometimes you want to trigger on SBUS_Ready at different lines of code, but reset it on an special line

so there should be a SBUS_Ready(bool reset) to decide if you want to reset or not

same for SBUS2_Ready()

@BrushlessPower BrushlessPower added the bug Something isn't working label Dec 8, 2020
@BrushlessPower
Copy link
Owner

BrushlessPower commented Jul 21, 2021

new functions:

SBUS_Ready(bool reset) and SBUS2_Ready(bool reset) -> true = reset / false = not reset
use false on your own risk

SBUS_Ready() and SBUS2_Ready() do reset the Flag on every call

Have to test it

@ericlangel ericlangel added the inProgress already working on that label Aug 5, 2021
@BrushlessPower BrushlessPower added Done Done but not commited and removed inProgress already working on that labels Mar 10, 2022
@ericlangel ericlangel added this to the Release V1.3 milestone May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Done Done but not commited
Projects
None yet
Development

No branches or pull requests

2 participants