-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New pipeline function for code usage | Updates on torch version #64
base: main
Are you sure you want to change the base?
Conversation
…e torch version(tested) | Added test case for BIDS I/O
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #64 +/- ##
==========================================
+ Coverage 71.03% 72.42% +1.39%
==========================================
Files 3 3
Lines 290 301 +11
==========================================
+ Hits 206 218 +12
+ Misses 84 83 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NiChart_Project (unfortunately) already relies on the run_pipeline interface. Can you change the function name quickly then ping me? Otherwise looks fine.
@AlexanderGetka-cbica It's run_ndlmuse_pipeline, i don't see the issue. |
I updated the torch version for up to 2.3.1 for now. The pipeline is tested and the torch version of the other packages(DLMUSE, DLICV, DLWMLS and Spare) will be updated as well once tested.
Also, implemented @AlexanderGetka-cbica 's request for a pipeline function (run_dlicv_pipeline) so it can be used instead of calling the CLI command inside third-party code.
Also, good thing that the installation of torch with cuda works well. Just fyi the pipeline works with torch 2.4.* versions as well(tested this because cuda 12.4 doesn't support 2.3.1)
P.S: Thanks for the VM Alex.