From b16bd38e7860ce5a924997eaa558d451510885af Mon Sep 17 00:00:00 2001 From: Kenji Tanaka Date: Wed, 18 Dec 2024 08:47:59 -0500 Subject: [PATCH] =?UTF-8?q?=F0=9F=94=A7=20chore(activities):=20Update=20pr?= =?UTF-8?q?eviews=20activity=20save=20process?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../marlo/action/projects/DeliverableAction.java | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/marlo-web/src/main/java/org/cgiar/ccafs/marlo/action/projects/DeliverableAction.java b/marlo-web/src/main/java/org/cgiar/ccafs/marlo/action/projects/DeliverableAction.java index bcf1dd2319..080a40d8ec 100644 --- a/marlo-web/src/main/java/org/cgiar/ccafs/marlo/action/projects/DeliverableAction.java +++ b/marlo-web/src/main/java/org/cgiar/ccafs/marlo/action/projects/DeliverableAction.java @@ -3069,16 +3069,14 @@ private void saveDeliverableActivities(Deliverable deliverablePrew) { for (DeliverableActivity deliverableActivity : deliverable.getActivities()) { if (deliverableActivity.getId() != null && deliverableActivity.getId() != -1) { - deliverableActivity = deliverableActivityManager.getDeliverableActivityById(deliverableActivity.getId()); - } - deliverableActivity.setDeliverable(deliverableManager.getDeliverableById(deliverableID)); - deliverableActivity.setPhase(this.getActualPhase()); - deliverableActivityManager.saveDeliverableActivity(deliverableActivity); - // This add projectFocus to generate correct auditlog. - deliverablePrew.getDeliverableActivities().add(deliverableActivity); + deliverableActivity.setDeliverable(deliverableManager.getDeliverableById(deliverableID)); + deliverableActivity.setPhase(this.getActualPhase()); + deliverableActivityManager.saveDeliverableActivity(deliverableActivity); + // This add projectFocus to generate correct auditlog. + deliverablePrew.getDeliverableActivities().add(deliverableActivity); + } } - } }