Skip to content

SurfDetectorConfig.h removed?  #39

@DhruvaKumar

Description

@DhruvaKumar

Hi,
I think in the recent commit (4f56532), the dependencies on SurfDetectorConfig.h have been removed.

However, there are still some files which require them like types.h (https://github.com/ccny-ros-pkg/ccny_rgbd_tools/blob/master/ccny_rgbd/include/ccny_rgbd/types.h)

Here's the build failure description while I tried installing ccny_rgbd_tools:
rosmake ccny_rgbd_tools

Building CXX object CMakeFiles/feature_viewer_node.dir/src/node/feature_viewer_node.cpp.o
Building CXX object CMakeFiles/feature_viewer_node.dir/src/apps/feature_viewer.cpp.o
Building CXX object CMakeFiles/feature_viewer_node.dir/src/util.cpp.o
make[3]: Entering directory `/home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/build'
[ 82%] [ 85%] Building CXX object CMakeFiles/visual_odometry_node.dir/src/node/visual_odometry_node.cpp.o
make[3]: Entering directory `/home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/build'
Building CXX object CMakeFiles/visual_odometry_node.dir/src/apps/visual_odometry.cpp.o
[ 87%] Building CXX object CMakeFiles/keyframe_mapper_node.dir/src/node/keyframe_mapper_node.cpp.o
In file included from /home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/include/ccny_rgbd/apps/feature_viewer.h:36:0,
                 from /home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/src/node/feature_viewer_node.cpp:24:
/home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/include/ccny_rgbd/types.h:45:42: fatal error: ccny_rgbd/SurfDetectorConfig.h: No such file or directory
compilation terminated.
In file included from /home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/include/ccny_rgbd/util.h:37:0,
                 from /home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/src/util.cpp:24:
/home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/include/ccny_rgbd/types.h:45:42: fatal error: ccny_rgbd/SurfDetectorConfig.h: No such file or directory
compilation terminated.
In file included from /home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/include/ccny_rgbd/util.h:37:0,
                 from /home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/src/util.cpp:24:
/home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/include/ccny_rgbd/types.h:45:42: fatal error: ccny_rgbd/SurfDetectorConfig.h: No such file or directory
compilation terminated.
In file included from /home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/include/ccny_rgbd/apps/rgbd_image_proc.h:35:0,
                 from /home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/src/apps/rgbd_image_proc.cpp:24:
/home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/include/ccny_rgbd/types.h:45:42: fatal error: ccny_rgbd/SurfDetectorConfig.h: No such file or directory
compilation terminated.
In file included from /home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/include/ccny_rgbd/apps/visual_odometry.h:36:0,
                 from /home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/src/apps/visual_odometry.cpp:24:
/home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/include/ccny_rgbd/types.h:45:42: fatal error: ccny_rgbd/SurfDetectorConfig.h: No such file or directory
compilation terminated.
In file included from /home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/include/ccny_rgbd/apps/visual_odometry.h:36:0,
                 from /home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/src/node/visual_odometry_node.cpp:24:
/home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/include/ccny_rgbd/types.h:45:42: fatal error: ccny_rgbd/SurfDetectorConfig.h: No such file or directory
compilation terminated.
In file included from /home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/include/ccny_rgbd/apps/keyframe_mapper.h:43:0,
                 from /home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/src/node/keyframe_mapper_node.cpp:24:
/home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/include/ccny_rgbd/types.h:45:42: fatal error: ccny_rgbd/SurfDetectorConfig.h: No such file or directory
compilation terminated.
In file included from /home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/include/ccny_rgbd/apps/feature_viewer.h:36:0,
                 from /home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/src/apps/feature_viewer.cpp:24:
/home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/include/ccny_rgbd/types.h:45:42: fatal error: ccny_rgbd/SurfDetectorConfig.h: No such file or directory
compilation terminated.
make[3]: *** [CMakeFiles/rgbd_image_proc_app.dir/src/apps/rgbd_image_proc.cpp.o] Error 1
make[3]: *** Waiting for unfinished jobs....
make[3]: *** [CMakeFiles/feature_viewer_node.dir/src/util.cpp.o] Error 1
make[3]: *** Waiting for unfinished jobs....
[ 92%] [ 92%] Building CXX object CMakeFiles/keyframe_mapper_node.dir/src/apps/keyframe_mapper.cpp.o
Building CXX object CMakeFiles/visual_odometry_node.dir/src/util.cpp.o
make[3]: *** [CMakeFiles/feature_viewer_node.dir/src/node/feature_viewer_node.cpp.o] Error 1
[ 95%] Building CXX object CMakeFiles/keyframe_mapper_node.dir/src/util.cpp.o
make[3]: *** [CMakeFiles/rgbd_image_proc_app.dir/src/util.cpp.o] Error 1
make[3]: Leaving directory `/home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/build'
make[2]: *** [CMakeFiles/rgbd_image_proc_app.dir/all] Error 2
make[2]: *** Waiting for unfinished jobs....
make[3]: *** [CMakeFiles/keyframe_mapper_node.dir/src/node/keyframe_mapper_node.cpp.o] Error 1
make[3]: *** Waiting for unfinished jobs....
make[3]: *** [CMakeFiles/visual_odometry_node.dir/src/apps/visual_odometry.cpp.o] Error 1
make[3]: *** Waiting for unfinished jobs....
make[3]: *** [CMakeFiles/visual_odometry_node.dir/src/node/visual_odometry_node.cpp.o] Error 1
make[3]: *** [CMakeFiles/feature_viewer_node.dir/src/apps/feature_viewer.cpp.o] Error 1
make[3]: Leaving directory `/home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/build'
make[2]: *** [CMakeFiles/feature_viewer_node.dir/all] Error 2
In file included from /home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/include/ccny_rgbd/util.h:37:0,
                 from /home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/src/util.cpp:24:
/home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/include/ccny_rgbd/types.h:45:42: fatal error: ccny_rgbd/SurfDetectorConfig.h: No such file or directory
compilation terminated.
In file included from /home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/include/ccny_rgbd/util.h:37:0,
                 from /home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/src/util.cpp:24:
/home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/include/ccny_rgbd/types.h:45:42: fatal error: ccny_rgbd/SurfDetectorConfig.h: No such file or directory
compilation terminated.
In file included from /home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/include/ccny_rgbd/apps/keyframe_mapper.h:43:0,
                 from /home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/src/apps/keyframe_mapper.cpp:24:
/home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/include/ccny_rgbd/types.h:45:42: fatal error: ccny_rgbd/SurfDetectorConfig.h: No such file or directory
compilation terminated.
make[3]: *** [CMakeFiles/keyframe_mapper_node.dir/src/util.cpp.o] Error 1
make[3]: *** [CMakeFiles/visual_odometry_node.dir/src/util.cpp.o] Error 1
make[3]: Leaving directory `/home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/build'
make[2]: *** [CMakeFiles/visual_odometry_node.dir/all] Error 2
make[3]: *** [CMakeFiles/keyframe_mapper_node.dir/src/apps/keyframe_mapper.cpp.o] Error 1
make[3]: Leaving directory `/home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/build'
make[2]: *** [CMakeFiles/keyframe_mapper_node.dir/all] Error 2
make[2]: Leaving directory `/home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/build'
make[1]: *** [all] Error 2
make[1]: Leaving directory `/home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/build'
make: *** [all] Error 2

What was the point of removing the SURF detector? Is it unnecessary?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions