From dbe5a929ced5beba883287194cfee802c6d36cd0 Mon Sep 17 00:00:00 2001 From: Jeff McJunkin Date: Tue, 25 Apr 2023 16:15:28 -0700 Subject: [PATCH] Fix build for Docker on Windows $env:pwd should just be $pwd, and you accidentally a word there at the end (`cmake --build` vs the existing plain `--build`) Honestly I ended up going with the Linux build via WSL2 anyway, so I added a hint there for future builders. --- README.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 5c0304f..020df2e 100644 --- a/README.md +++ b/README.md @@ -97,7 +97,7 @@ If you have docker installed, this is the quickest option. It utilises the `ccob #### Docker on Windows (Powershell) ```shell -docker run --rm -it -v $env:pwd\:/root/lsarelayx ccob/windows_cross:latest /bin/bash -c "cd /root/lsarelayx; mkdir build; cd build; cmake -DCMAKE_INSTALL_PREFIX=/root/lsarelayx/dist -DCMAKE_BUILD_TYPE=MinSizeRel -DCMAKE_TOOLCHAIN_FILE=../toolchain/Linux-mingw64.cmake ..; --build . --target install/strip" +docker run --rm -it -v $pwd\:/root/lsarelayx ccob/windows_cross:latest /bin/bash -c "cd /root/lsarelayx; mkdir build; cd build; cmake -DCMAKE_INSTALL_PREFIX=/root/lsarelayx/dist -DCMAKE_BUILD_TYPE=MinSizeRel -DCMAKE_TOOLCHAIN_FILE=../toolchain/Linux-mingw64.cmake ..; cmake --build . --target install/strip" ``` #### Docker on Linux @@ -108,7 +108,7 @@ docker run --rm -it -v $(pwd):/root/lsarelayx ccob/windows_cross:latest /bin/bas ### Linux -On Linux we utilise a CMake toolchain along with the MinGW compiler. These need to be installed before hand. For the managed component, please make sure the dotnet command line tool is also installed from .NET core +On Linux we utilise a CMake toolchain along with the MinGW compiler. These need to be installed before hand. For the managed component, please make sure the dotnet command line tool is also installed from .NET core (for Ubuntu, something like `sudo apt install dotnet6`) ```shell mkdir build @@ -126,4 +126,4 @@ mkdir build cd build cmake -DCMAKE_INSTALL_PREFIX=$PWD/dist -DCMAKE_BUILD_TYPE=MinSizeRel -G "MinGW Makefiles" .. cmake --build . --target install/strip -``` \ No newline at end of file +```