diff --git a/package-lock.json b/package-lock.json index 2eefa2c..2910b84 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,6 +1,6 @@ { "name": "@cda0/terrajs", - "version": "0.5.1", + "version": "0.5.2", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/package.json b/package.json index d30e356..df71d70 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@cda0/terrajs", - "version": "0.5.1", + "version": "0.5.2", "description": "A node interface to Terraform", "main": "src/index.js", "scripts": { diff --git a/src/helpers.js b/src/helpers.js index 21e84a6..9d1b8c0 100644 --- a/src/helpers.js +++ b/src/helpers.js @@ -33,12 +33,13 @@ function parseVariable(key, value) { return `'${parsedKey}=${parsedValue.replace(/'/g, '\\\'')}'`; } - if (typeof value === 'boolean') { - return `"${parsedKey}=${value}"`; + if (typeof value === 'string') { + // Double-quotes can prematurely close the string, so they need to be escaped. + return `"${parsedKey}=${value.replace(/"/g, '\\"')}"`; } - // Double-quotes can prematurely close the string, so they need to be escaped. - return `"${parsedKey}=${value.replace(/"/g, '\\"')}"`; + // Booleans and numbers can be returned without parsing. + return `"${parsedKey}=${value}"`; } module.exports = { diff --git a/test/unit/helpers.test.js b/test/unit/helpers.test.js index 082c5d9..c62bbed 100644 --- a/test/unit/helpers.test.js +++ b/test/unit/helpers.test.js @@ -89,6 +89,12 @@ describe('helpers', () => { assert.equal(response, '"some_var=West Europe"'); }); + it('should correctly parse a number variable', () => { + const variable = 42; + const response = parseVariable('someVar', variable); + assert.equal(response, '"some_var=42"'); + }); + it('should correctly parse a boolean variable', () => { const variable = true; const response = parseVariable('someVar', variable); @@ -137,6 +143,12 @@ describe('helpers', () => { assert.equal(response, '"some_var=West Europe"'); }); + it('should correctly parse a number variable', () => { + const variable = 42; + const response = parseVariable('someVar', variable); + assert.equal(response, '"some_var=42"'); + }); + it('should correctly parse a boolean variable', () => { const variable = true; const response = parseVariable('someVar', variable);