From b9de8c8dfd4871fc14941ce20ee79f1448fe3689 Mon Sep 17 00:00:00 2001 From: halprin Date: Mon, 7 Oct 2024 13:28:53 -0600 Subject: [PATCH 1/3] Added new e2e tests created to the DOD --- .github/ISSUE_TEMPLATE/story.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/ISSUE_TEMPLATE/story.md b/.github/ISSUE_TEMPLATE/story.md index 62567ab89..7f8fd4aa9 100644 --- a/.github/ISSUE_TEMPLATE/story.md +++ b/.github/ISSUE_TEMPLATE/story.md @@ -45,6 +45,8 @@ As a _, so that _, I need _. - [ ] Testing tasks completed - [ ] Load tests passed - [ ] Unit test coverage of our code >= 90% + - [ ] Additional e2e tests created + - [ ] Additional RS e2e tests created for any new transformations. Includes improvements to the assertion code required to make the new tests - [ ] Build & Deploy tasks completed - [ ] Build process updated - [ ] API(s) are versioned From 53db47ede94bc178c22e3c656f1f734fcc1842fa Mon Sep 17 00:00:00 2001 From: halprin Date: Mon, 7 Oct 2024 13:31:24 -0600 Subject: [PATCH 2/3] Removed PR check items from the DOD --- .github/ISSUE_TEMPLATE/story.md | 5 ----- 1 file changed, 5 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/story.md b/.github/ISSUE_TEMPLATE/story.md index 7f8fd4aa9..3b974a500 100644 --- a/.github/ISSUE_TEMPLATE/story.md +++ b/.github/ISSUE_TEMPLATE/story.md @@ -38,13 +38,8 @@ As a _, so that _, I need _. - [ ] Code quality tasks completed - [ ] Code refactored for clarity and no design/technical debt - [ ] Adhere to separation of concerns; code is not tightly coupled, especially to 3rd party dependencies - - [ ] Code is reviewed or developed by pair; 1 approval is needed but consider requiring an outside-the-pair reviewer - - [ ] Code quality checks passed -- [ ] Security & Privacy tasks completed - - [ ] Security & privacy gates passed - [ ] Testing tasks completed - [ ] Load tests passed - - [ ] Unit test coverage of our code >= 90% - [ ] Additional e2e tests created - [ ] Additional RS e2e tests created for any new transformations. Includes improvements to the assertion code required to make the new tests - [ ] Build & Deploy tasks completed From e5212b51bafe5778af1c3c1921e25e31b603508e Mon Sep 17 00:00:00 2001 From: halprin Date: Tue, 8 Oct 2024 08:34:12 -0600 Subject: [PATCH 3/3] Rewrite rs-e2e DoD item --- .github/ISSUE_TEMPLATE/story.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/story.md b/.github/ISSUE_TEMPLATE/story.md index 3b974a500..f10d389d5 100644 --- a/.github/ISSUE_TEMPLATE/story.md +++ b/.github/ISSUE_TEMPLATE/story.md @@ -41,7 +41,7 @@ As a _, so that _, I need _. - [ ] Testing tasks completed - [ ] Load tests passed - [ ] Additional e2e tests created - - [ ] Additional RS e2e tests created for any new transformations. Includes improvements to the assertion code required to make the new tests + - [ ] Additional RS e2e assertions created in the `rs-e2e` project for any new transformations. Includes improvements to the assertion code required to make the new assertions - [ ] Build & Deploy tasks completed - [ ] Build process updated - [ ] API(s) are versioned