You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The documentation for gtf2gtf --method=exons2introns says:
exons2introns
Merges overlapping introns for all transcripts of a gene,
outputting the merged introns.
But this is not what exons2introns does. Taken the following example with two transcripts:
Input:
|>>>>>|----------|>>>>>>|
|>>>>>|------------|>>>>|
| | |
Output: | | |
|>>>>>>>>>>| | Actual Output
|>>>>>>>>>>>>| Described Output
As described I would expect the output to be as indicated by "Described Ouput", but that isn't what you get, you get what is described by "Actual Output" - which is the result of intersecting introns, not merging them.
Does anyone know of anywhere this is used? Should we change the documentation to match what actually happens, or change what happens to match the documentation?
The text was updated successfully, but these errors were encountered:
It seems as though this is used in the buildIntronGeneModels of pipeline mapping. I can't see it being used anywhere else.
The documentation is as follows:
Retain the protein coding genes from the input gene set and
convert the exonic sequences to intronic sequences. 10 bp is
truncated on either end of an intron and need to have a minimum
length of 100. Introns from nested genes might overlap, but all
exons are removed.
The only issue I can see is that our pipeline_mapping tests may fail if we made changes to the code. I will try and have a look at what tests are implemented today if I have time and get back to you on this.
Since buildIntronLevelReadCounts function is only used to count the number of reads that overlap introns and doesn't really get used in the downstream analysis of our data, my feeling would be to change the documentation to reflect the code. However, @sebastian-luna-valero and @AndreasHeger may have differing opinions.
If you provide some toy input data to reproduce the issue in gtf2gtf --method=exons2introns, I am happy to have a look and update either the code or the docs depending on what we decide, and provide a test to capture this scenario.
The documentation for
gtf2gtf --method=exons2introns
says:But this is not what
exons2introns
does. Taken the following example with two transcripts:As described I would expect the output to be as indicated by "Described Ouput", but that isn't what you get, you get what is described by "Actual Output" - which is the result of intersecting introns, not merging them.
Does anyone know of anywhere this is used? Should we change the documentation to match what actually happens, or change what happens to match the documentation?
The text was updated successfully, but these errors were encountered: