Skip to content

Commit 1617791

Browse files
luiscomspetervanderdoes
authored andcommitted
Add --noedit flag that accept the auto-generated message on merging
1 parent a941a2a commit 1617791

File tree

2 files changed

+16
-8
lines changed

2 files changed

+16
-8
lines changed

AUTHORS

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@ Justin Penney
5555
Konstantin Tjuterev
5656
Kridsada Thanabulpong
5757
Leonardo Giordani
58+
Luis Fernando Gomes @luiscoms
5859
Mark Borcherding
5960
Mark Derricutt
6061
Mateusz Kaczmarek

git-flow-release

Lines changed: 15 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -104,12 +104,15 @@ _finish_from_develop() {
104104
# but the merge into master was successful, we skip it now
105105
if ! git_is_branch_merged_into "$BRANCH" "$MASTER_BRANCH"; then
106106
git_do checkout "$MASTER_BRANCH" || die "Could not check out branch '$MASTER_BRANCH'."
107+
108+
opts=""
109+
noflag edit && opts="$opts --no-edit"
107110
if noflag squash; then
108-
git_do merge --no-ff "$BRANCH" || die "There were merge conflicts." # TODO: What do we do now?
111+
git_do merge --no-ff $opts "$BRANCH" || die "There were merge conflicts." # TODO: What do we do now?
109112
else
110-
git_do merge --squash "$BRANCH" || die "There were merge conflicts." # TODO: What do we do now?
113+
git_do merge --squash $opts "$BRANCH" || die "There were merge conflicts." # TODO: What do we do now?
111114
flag squash_info && gitflow_create_squash_message "Merged release branch '$BRANCH'" "$MASTER_BRANCH" "$BRANCH" > "$DOT_GIT_DIR/SQUASH_MSG"
112-
git_do commit
115+
git_do commit $opts
113116
fi
114117
fi
115118

@@ -150,6 +153,8 @@ _finish_from_develop() {
150153
if ! git_is_branch_merged_into "$merge_branch" "$DEVELOP_BRANCH"; then
151154
git_do checkout "$DEVELOP_BRANCH" || die "Could not check out branch '$DEVELOP_BRANCH'."
152155

156+
opts=""
157+
noflag edit && opts="$opts --no-edit"
153158
if noflag nobackmerge; then
154159
# Accounting for 'git describe', if a release is tagged
155160
# we use the tag commit instead of the branch.
@@ -158,15 +163,15 @@ _finish_from_develop() {
158163
else
159164
commit="$MASTER_BRANCH"
160165
fi
161-
git_do merge --no-ff "$commit" || die "There were merge conflicts." # TODO: What do we do now?
166+
git_do merge --no-ff $opts "$commit" || die "There were merge conflicts." # TODO: What do we do now?
162167
else
163168
commit="$BRANCH"
164169
if noflag squash; then
165-
git_do merge --no-ff "$commit" || die "There were merge conflicts." # TODO: What do we do now?
170+
git_do merge --no-ff $opts "$commit" || die "There were merge conflicts." # TODO: What do we do now?
166171
else
167-
git_do merge --squash "$commit" || die "There were merge conflicts." # TODO: What do we do now?
172+
git_do merge --squash $opts "$commit" || die "There were merge conflicts." # TODO: What do we do now?
168173
flag squash_info && gitflow_create_squash_message "Merged release branch '$BRANCH'" "$DEVELOP_BRANCH" "$BRANCH" > "$DOT_GIT_DIR/SQUASH_MSG"
169-
git_do commit
174+
git_do commit $opts
170175
fi
171176
fi
172177
fi
@@ -603,7 +608,7 @@ v,verbose! Verbose (more) output
603608

604609
cmd_finish() {
605610
OPTIONS_SPEC="\
606-
git flow release finish [-h] [-F] [-s] [-u] [-m | -f] [-p] [-k] [-n] [-b] [-S] <version>
611+
git flow release finish [-h] [-F] [-s] [-u] [-m | -f] [-p] [-k] [-n] [-b] [-S] [-e] <version>
607612
608613
609614
Finish a release branch
@@ -627,6 +632,7 @@ n,[no]tag Don't tag this release
627632
b,[no]nobackmerge Don't back-merge master, or tag if applicable, in develop
628633
S,[no]squash Squash release during merge
629634
[no]ff-master Fast forward master branch if possible
635+
e,[no]edit The --noedit option can be used to accept the auto-generated message on merging
630636
T,tagname! Use given tag name
631637
nodevelopmerge! Don't back-merge develop branch
632638
"
@@ -649,6 +655,7 @@ nodevelopmerge! Don't back-merge develop branch
649655
DEFINE_boolean 'squash' false "squash release during merge" S
650656
DEFINE_boolean 'squash-info' false "add branch info during squash"
651657
DEFINE_boolean 'ff-master' false "fast forward master branch if possible"
658+
DEFINE_boolean 'edit' true "accept the auto-generated message on merging" e
652659
DEFINE_string 'tagname' "" "use the given tag name" T
653660
DEFINE_boolean 'nodevelopmerge' false "don't merge $BRANCH into $DEVELOP_BRANCH "
654661

0 commit comments

Comments
 (0)