Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order of zappi charge mode vs eddi operating mode #403

Open
reedy opened this issue Sep 8, 2023 · 3 comments
Open

Order of zappi charge mode vs eddi operating mode #403

reedy opened this issue Sep 8, 2023 · 3 comments

Comments

@reedy
Copy link
Contributor

reedy commented Sep 8, 2023

Screenshot 2023-09-08 at 10 55 21
Screenshot 2023-09-08 at 10 55 17

These are obviously how they display in https://github.com/CJNE/ha-myenergi, but from a quick glance the "order" is as per the ordering in this library:

https://github.com/CJNE/pymyenergi/blob/6e958aeadd44a1bf734e10c0727243ee4c590dd1/pymyenergi/zappi.py#L6

https://github.com/CJNE/pymyenergi/blob/6e958aeadd44a1bf734e10c0727243ee4c590dd1/pymyenergi/eddi.py#L22

The difference in ordering (at least, related to the "Stopped") irks me a little.

Can we move "Stopped" on the eddi to second place without causing any issues? Presumably needing to change the "default" too in charge_mode...

@CJNE
Copy link
Owner

CJNE commented Sep 12, 2023

Thanks for the suggestion!
However, the index of those strings directly relates to what command to send to the API, so they make sense to be like this here.
So this would be better solved in ha-myenergi.

@CJNE CJNE closed this as completed Sep 12, 2023
@reedy
Copy link
Contributor Author

reedy commented Sep 12, 2023

Want to transfer the issue over? :)

@CJNE CJNE transferred this issue from CJNE/pymyenergi Sep 12, 2023
@CJNE CJNE reopened this Sep 12, 2023
@reedy
Copy link
Contributor Author

reedy commented Sep 12, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants