Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Barcode #85

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Barcode #85

merged 2 commits into from
Nov 28, 2023

Conversation

Sami-Jagirdar
Copy link
Contributor

@Sami-Jagirdar Sami-Jagirdar commented Nov 27, 2023 •
edited
Loading

Describe your changes

This PR accomplishes the following:

  • Allows user to scan barcode of an image either taken using the camera or selected from the gallery
  • The barcode is decoded
  • The type of the decoded value is checked to see if it falls in the category of either Text type or Product type
    • If yes, decoded value is likely a serial number and user is given the choice to set it as either item description or serial number
    • If no, allow user to set decoded value as item description only

Issue ticket number and link

This PR addresses: #12

Checklist before requesting a review

  • I have performed a self-review of my code
  • Necessary java docs are present
  • Necessary UML diagrams are created
  • Necessary tests are written

Screenshots (if applicable)

e.g. UI screenshots, UML screenshots, etc

@Sami-Jagirdar Sami-Jagirdar marked this pull request as ready for review November 28, 2023 08:16
@ldbonkowski ldbonkowski changed the base branch from main to serial-scanning November 28, 2023 20:39
ldbonkowski
ldbonkowski approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@ldbonkowski ldbonkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

MatthewNeufeld
MatthewNeufeld approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@MatthewNeufeld MatthewNeufeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work Sami - another really cool feature. LGTM.

@ldbonkowski ldbonkowski merged commit 520bd7a into serial-scanning Nov 28, 2023
1 of 2 checks passed
ldbonkowski added a commit that referenced this pull request Nov 28, 2023
@ldbonkowski @Sami-Jagirdar
Serial scanning (#84)
15d250a 
* Serial num scanning

* Serial num scanning works

* Javadocs

* Reduced spacing

* Fixed misplaced dismiss

* Serial num alphanumeric

* Barcode (#85)

* Very rough Barcode Scanning

* Polished the barcode scanner giving users more options

* Add pop up

---------

Co-authored-by: Sami-Jagirdar <72996716+Sami-Jagirdar@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatthewNeufeld MatthewNeufeld MatthewNeufeld approved these changes

@ldbonkowski ldbonkowski ldbonkowski approved these changes

@owencooke owencooke Awaiting requested review from owencooke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sami-Jagirdar @ldbonkowski @MatthewNeufeld