Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serial num scanning espresso test #90

Merged
merged 5 commits into from
Nov 29, 2023
Merged

Serial num scanning espresso test #90

merged 5 commits into from
Nov 29, 2023

Conversation

ldbonkowski
Copy link
Contributor

@ldbonkowski ldbonkowski commented Nov 29, 2023

Describe your changes

This PR accomplishes the following:

  • serial num scanning test

Issue ticket number and link

This PR addresses: #<link_to_issue>

Checklist before requesting a review

  • I have performed a self-review of my code
  • Necessary java docs are present
  • Necessary UML diagrams are created
  • Necessary tests are written

Screenshots (if applicable)

e.g. UI screenshots, UML screenshots, etc

Copy link
Contributor

@Sami-Jagirdar Sami-Jagirdar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test passes on my end. LGTM!

ldbonkowski and others added 3 commits November 29, 2023 10:49
* added test image for barcode ui test

* UI tests for barcode scanning

* Small refactoring of BarcodeScanner class
Copy link
Contributor

@owencooke owencooke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests look really great, good job guys. Ran it on local just to double check, all good ✔️

@ldbonkowski ldbonkowski merged commit df0c69e into main Nov 29, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants